pepepper/fluxer
1
0
Fork 0
mirror of https://github.com/fluxerapp/fluxer synced 2026-10-07 19:22:14 +09:00
Code Issues Packages Projects Releases Wiki Activity

fix(voice): make RNNoise the default noise suppression (#3103)

Browse Source
This commit is contained in:
Hampus
2026-10-02 11:31:40 +02:00
committed by GitHub
parent 98cce4815d
commit 4e6f9b539c
2 changed files with 16 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
fluxer_app/src/features/voice/state/VoiceSettings.ts
+15
View File
@@ -386,6 +386,17 @@ export function applyLegacyNoiseSuppressionNoneMigrationV1(parsed: Record<string
return changed;
}
function applyDeepFilterDefaultRetiredMigrationV1(parsed: Record<string, unknown>): boolean {
if (parsed.deepFilterDefaultRetiredMigratedV1 === true) {
return false;
}
if (parsed.noiseSuppressionBackendPrefV1 === 'deep_filter') {
parsed.noiseSuppressionBackendPrefV1 = null;
}
parsed.deepFilterDefaultRetiredMigratedV1 = true;
return true;
}
function validateNoiseSuppressionBackend(value: unknown): VoiceNoiseSuppressionBackend | null {
return isVoiceNoiseSuppressionBackend(value) ? value : null;
}
@@ -460,6 +471,7 @@ class VoiceSettings {
screenShareHevcOptIn = false;
screenShareAv1OptOutMigratedV1 = false;
screenShareHevcOptOutMigratedV1 = false;
deepFilterDefaultRetiredMigratedV1 = false;
screenShareContentHintPrefV2: ScreenShareContentHint = DEFAULT_SCREEN_SHARE_CONTENT_HINT;
screenShareContentHintDefaultMigratedV1 = false;
screenShareSoftwareQualityRetiredV1 = false;
@@ -583,6 +595,7 @@ class VoiceSettings {
changed = applyScreenShareSoftwareQualityRetiredMigrationV1(parsed) || changed;
changed = applyScreenShareBackupCodecModeRetiredMigrationV1(parsed) || changed;
changed = applyLegacyNoiseSuppressionNoneMigrationV1(parsed) || changed;
changed = applyDeepFilterDefaultRetiredMigrationV1(parsed) || changed;
if (changed) {
AppStorage.setItem('VoiceSettings', JSON.stringify(parsed));
}
@@ -590,6 +603,7 @@ class VoiceSettings {
this.screenShareAv1OptOutMigratedV1 = parsed.screenShareAv1OptOutMigratedV1 === true;
this.screenShareHevcOptOutMigratedV1 = parsed.screenShareHevcOptOutMigratedV1 === true;
this.manualAudioSourcesOptOutResetMigratedV1 = parsed.manualAudioSourcesOptOutResetMigratedV1 === true;
this.deepFilterDefaultRetiredMigratedV1 = parsed.deepFilterDefaultRetiredMigratedV1 === true;
} catch (error) {
logger.warn('Failed to migrate persisted voice settings:', error);
}
@@ -643,6 +657,7 @@ class VoiceSettings {
'screenShareHevcOptIn',
'screenShareAv1OptOutMigratedV1',
'screenShareHevcOptOutMigratedV1',
'deepFilterDefaultRetiredMigratedV1',
'screenShareContentHintPrefV2',
'screenShareContentHintDefaultMigratedV1',
'screenShareSoftwareQualityRetiredV1',
fluxer_app/src/features/voice/utils/noise_suppression/NoiseSuppressionSelection.ts
+1 -1
View File
@@ -11,7 +11,7 @@ import {
import type {ResolvedVoiceProcessing} from '@app/features/voice/utils/VoiceProcessingProfile';
const NOISE_SUPPRESSION_SAMPLE_RATE = 48000;
const DEFAULT_NOISE_SUPPRESSION_BACKEND: VoiceNoiseSuppressionBackend = 'deep_filter';
const DEFAULT_NOISE_SUPPRESSION_BACKEND: VoiceNoiseSuppressionBackend = 'rnnoise';
export function readNoiseSuppressionRuntimeCapabilities(): NoiseSuppressionRuntimeCapabilities {
return {