[workflows/ci.yml] Run CI on PRs

[YoutubeDL] Raise syntax error for format selection expressions with multiple + operators (closes #27803 )
2024-10-23 03:28:01 +09:00 · 2021-01-14 02:54:38 +07:00 · 2021-01-14 00:38:31 +07:00
3 changed files with 4 additions and 1 deletions
--- a/.github/workflows/ci.yml
+++ b/.github/workflows/ci.yml
@ -1,5 +1,5 @@
 name: CI
-on: [push]
+on: [push, pull_request]
 jobs:
  tests:
    name: Tests
--- a/test/test_YoutubeDL.py
+++ b/test/test_YoutubeDL.py
@ -464,6 +464,7 @@ class TestFormatSelection(unittest.TestCase):
        assert_syntax_error('+bestaudio')
        assert_syntax_error('bestvideo+')
        assert_syntax_error('/')
+        assert_syntax_error('bestvideo+bestvideo+bestaudio')

    def test_format_filtering(self):
        formats = [
--- a/youtube_dl/YoutubeDL.py
+++ b/youtube_dl/YoutubeDL.py
@ -1226,6 +1226,8 @@ class YoutubeDL(object):
                        group = _parse_format_selection(tokens, inside_group=True)
                        current_selector = FormatSelector(GROUP, group, [])
                    elif string == '+':
+                        if inside_merge:
+                            raise syntax_error('Unexpected "+"', start)
                        video_selector = current_selector
                        audio_selector = _parse_format_selection(tokens, inside_merge=True)
                        if not video_selector or not audio_selector:
Author	SHA1	Message	Date
Sergey M․	1e8e5d5238	[workflows/ci.yml] Run CI on PRs	2021-01-14 02:54:38 +07:00
Sergey M․	d81a213cfb	[YoutubeDL] Raise syntax error for format selection expressions with multiple + operators (closes #27803 )	2021-01-14 00:38:31 +07:00