Compare commits

...

3 Commits

Author SHA1 Message Date
Alex Richards
2c9341091d
Merge e8bebe0b03d256371c38a983d7a6d2147d827cba into 3eb8d22ddb8982ca4fb56bb7a8d6517538bf14c6 2025-04-01 08:07:18 +02:00
dirkf
3eb8d22ddb
[JSInterp] Temporary fix for #33102 2025-03-31 04:21:09 +01:00
Alex Richards
e8bebe0b03 [postprocessor/ffmpeg] Allow options for mp3
Why?
Options like `preferredquality` are ignored when postprocessing mp3s.

What?
Remove `mp3` from the list of `filecodec` values to check for in the
"lossless" condition unless `preferredquality` is unspecified.
2023-08-17 07:48:20 -07:00
2 changed files with 6 additions and 1 deletions

View File

@ -686,6 +686,8 @@ class JSInterpreter(object):
raise self.Exception('Cannot get index {idx!r:.100}'.format(**locals()), expr=repr(obj), cause=e)
def _dump(self, obj, namespace):
if obj is JS_Undefined:
return 'undefined'
try:
return json.dumps(obj)
except TypeError:

View File

@ -276,7 +276,10 @@ class FFmpegExtractAudioPP(FFmpegPostProcessor):
acodec = 'copy'
extension = 'm4a'
more_opts = ['-bsf:a', 'aac_adtstoasc']
elif filecodec in ['aac', 'flac', 'mp3', 'vorbis', 'opus']:
elif (
filecodec in ['aac', 'flac', 'vorbis', 'opus'] or
(filecodec == 'mp3' and self._preferredquality is None)
):
# Lossless if possible
acodec = 'copy'
extension = filecodec