Sergey M․
25dd58ca6a
[metadatafromtitle] Remove unused exception class
2016-08-09 04:01:05 +07:00
nyorain
5e42f8a0ad
Make --metadata-from-title non fatal
...
Output a warning if the metadata can't be parsed from the title (and don't write any metadata) instead of raising a critical error.
2016-08-09 03:56:22 +07:00
Yen Chi Hsuan
23495d6a39
Revert "[ffmpeg] Fix embedding subtitles ( #9063 )"
...
This reverts commit ccff2c404d
.
Fixes #10081 .
The new approach breaks embedding subtitles into video-only or
audio-only files. FFMpeg provides a trick: add '?' after the argument of
'-map' so that a missing stream is ignored. For example:
opts = [
'-map', '0:v?',
'-c:v', 'copy',
'-map', '0:a?',
'-c:a', 'copy',
# other options...
]
Unfortunately, such a format is not implemented in avconv, either.
I guess adding '-ignore_unknown' if self.basename == 'ffmpeg' is the
best solution. However, the example mentioned in #9063 no longer serves
problematic files, so I can't test it. I'll reopen #9063 and wait for
another example so that I can test '-ignore_unknown'.
2016-07-15 20:02:36 +08:00
Yen Chi Hsuan
5b6a74856b
Merge pull request #9288 from reyyed/issue#9063fix
...
[ffmpeg] Fix embedding subtitles (#9063 )
2016-07-09 14:29:53 +08:00
Yen Chi Hsuan
702ccf2dc0
[compat] Rename shlex_quote and remove unused subprocess_check_output
2016-05-10 16:00:21 +08:00
Sergey M․
4bd143a3a0
[postprocessor/ffmpeg] Simplify metadata preparation and add track related metafields ( Closes #9357 )
2016-05-01 10:56:54 +06:00
Wang Jun Tham
ccff2c404d
[ffmpeg] Fix embedding subtitles ( #9063 )
...
Changed command line parameters for ffmpeg when embedding subtitles.
Changed to ‘-map 0:v -c:v copy -map 0:a -c:a copy’
2016-04-24 00:08:02 +08:00
remitamine
b9f2fdd37f
[ffmpeg] Clarify rationale for pipe(-) exclusion in _ffmpeg_filename_argument
2016-04-16 21:50:13 +01:00
remitamine
d868f43c58
[ffmpeg] check for - file name in _ffmpeg_filename_argument
2016-04-16 19:45:56 +01:00
remitamine
0750b2491f
[ffmpeg] try to convert tt subtitles usng dfxp2srt
2016-04-01 19:47:49 +01:00
Sergey M․
40025ee2a3
[postprocessort/ffmpeg] Allow embedding webvtt into webm ( Closes #8874 )
2016-03-20 04:12:34 +06:00
remitamine
2e7e561c1d
Merge pull request #8611 from remitamine/ffmpegfd
...
[downloader/external] Add FFmpegFD
2016-03-13 21:30:27 +01:00
remitamine
a755f82549
[ffmpeg] convert format ext to ffmpeg output formats codes
2016-03-13 12:15:29 +01:00
remitamine
090eb8e25f
Merge pull request #8718 from remitamine/m3u8-fixup
...
Add fixup for media files produced by HlsNative downloader(fixes #4776 )
2016-03-05 18:37:28 +01:00
Yen Chi Hsuan
e9c0cdd389
[jython] Introduce compat_os_name
...
os.name is always 'java' on Jython
2016-03-03 19:24:24 +08:00
remitamine
f17f86513e
Add fixup for media files produced by HlsNative downloader( fixes #4776 )
2016-03-01 21:10:41 +01:00
Yen Chi Hsuan
7360db05b4
[postprocessor/embedthumbnail] Allow mkv to embed thumbnails
...
Fixes #6046
2016-02-21 03:32:03 +08:00
Sergey M․
611c1dd96e
[refactor] Single quotes consistency
2016-02-14 15:37:17 +06:00
Jaime Marquínez Ferrándiz
d4f8e83404
[FFmpegSubtitlesConvertorPP] remove unused variable
2016-02-06 19:04:53 +01:00
Jaime Marquínez Ferrándiz
7b8b007cd9
[FFmpegSubtitlesConvertorPP] remove intermediate srt files
2016-02-06 19:04:18 +01:00
Jaime Marquínez Ferrándiz
3547d26587
[FFmpegSubtitlesConvertorPP] correctly update the extension ( fixes #8444 )
2016-02-06 18:58:18 +01:00
Jaime Marquínez Ferrándiz
7e62c2eb6d
[FFmpegSubtitlesConvertorPP] fix not working when srt is used as the intermediate format between ttml/dfxp and other format
...
It was trying to use the ttml/dfxp file with ffmpeg, which doesn't have support for them.
I broke it in e04398e397
.
2016-02-06 18:51:05 +01:00
remitamine
7d3a035ee0
[ffmpeg] check for m3u8 protocol in FFmpegMetadataPP
2016-02-05 17:12:49 +01:00
remitamine
593e0f43b4
[ffmpeg] fix condition( fixes #8440 )
2016-02-05 15:12:06 +01:00
remitamine
6fba62c87a
[ffmpeg] fix adding metadata when using --hls-prefer-native( #8350 )
2016-02-02 22:14:23 +01:00
remitamine
fae45ede08
Merge pull request #8354 from remitamine/m3u8_metadata
...
[ffmpeg] fix adding metadata when using m3u8_native(fixes #8350 )
2016-02-02 19:13:58 +01:00
Jaime Marquínez Ferrándiz
e04398e397
[FFmpegSubtitlesConvertorPP] delete old subtitle files ( fixes #8382 )
2016-01-31 14:22:36 +01:00
remitamine
cf57433bbd
[ffmpeg] fix adding metadata when using m3u8_native( fixes #8350 )
2016-01-28 18:57:32 +01:00
Juan M Martínez
374c761e77
[FFmpegPostProcessor] Default of prefer ffmpeg
...
When no `downloader` is passed to `FFmpegPostProcessor`
an exception was raised trying to get the prefer ffmpeg param.
AttributeError: 'NoneType' object has no attribute 'params'
This fixes and defaults to `False`.
2015-12-09 20:56:00 -03:00
Sergey M․
deb85c32bb
[postprocessor/ffmpeg] Use ffmpeg as prefix since it's used all over the places ( Closes #7371 )
2015-11-06 21:56:31 +06:00
Jaime Marquínez Ferrándiz
8a7bbd1606
[postprocessor/ffmpeg] Always use the 'file:' protocol for filenames ( fixes #6874 )
...
If the filename contains ':' it is interpreted as a protocol.
It also handles filenames starting with '-'.
2015-09-18 14:38:35 +02:00
Jaime Marquínez Ferrándiz
3026164b16
[postprocessor/common] Use 'self._downloader.params' instead of 'self.params'
...
'self.params' is not defined
2015-09-05 12:11:36 +02:00
Sergey M․
6270239a6d
[postprocessor/common] Use generalized cli option converters
2015-09-05 03:06:53 +06:00
Jaime Marquínez Ferrándiz
9750e7d70e
[postprocessor/ffmpeg] Don't use '[youtube] ...' in messages
...
Because it can be used for other extractors.
2015-07-14 12:56:32 +02:00
Sergey M․
15006fedb9
[postprocessor/ffmpeg] Spread postprocessor args usage on all ffmpeg extractors
2015-07-11 22:42:03 +06:00
Sergey M․
e35b23f54d
[postprocessor/common] Improve postprocessor args fetching and clarify doc
2015-07-11 22:41:33 +06:00
Sergey M․
f72b0a6032
Revert xvid to avi and make docs to be similar to existing external downloader option
2015-07-11 22:15:16 +06:00
Sergey M․
ac9ed061ec
Merge branch 'master' of https://github.com/aurium/youtube-dl into aurium-master
2015-07-11 21:58:12 +06:00
Aurélio A. Heckert
aa5d9a79d6
Simplify postprocessor_args
transmission to PP base class
...
* Remove `extra_cmd_args` transmission from sub to super class.
* Simplify params transmission through `downloader.params`.
2015-07-01 20:12:26 -03:00
Aurélio A. Heckert
1866432db7
Rename --pp-params to --postprocessor-args and access value as super class attribute
2015-06-30 16:22:09 -03:00
Yen Chi Hsuan
396726244a
[utils/ffmpeg] Move ISO 639 related codes to utils
2015-06-21 18:53:17 +08:00
Yen Chi Hsuan
c33a8639a7
[postprocessor/embedthumbnail] Skipping if thumbnail file missing
...
Fixes #5996
2015-06-18 22:05:02 +08:00
Aurélio A. Heckert
14835de9fb
Use shlex.split for --pp-params and update related docs.
2015-06-16 18:10:31 -03:00
Aurélio A. Heckert
d84f1d14b5
Adds support for XviD output with extra parametrization
...
As the "LG Time Machine" (a (not so) smart TV) has a limitation for video dimensions (as for codecs), I take to implement an extra parameter `--pp-params` where we can send extra parameterization for the video converter (post-processor).
Example:
```
$ youtube-dl --recode-video=xvid --pp-params='-s 720x480' -c https://www.youtube.com/watch?v=BE7Qoe2ZiXE
```
That works fine on a 4yo LG Time Machine.
Closes #5733
2015-06-09 22:08:16 -03:00
pulpe
d6aa68ce75
[postprocessor/embedthumbnail] embed mp4 too ( fixes #5840 )
2015-05-29 12:47:20 +02:00
Sergey M․
98b8ec8616
Merge branch 'best-fallback-on-outdated-avconv' of https://github.com/dstftw/youtube-dl into dstftw-best-fallback-on-outdated-avconv
...
Conflicts:
youtube_dl/YoutubeDL.py
2015-05-14 15:18:58 +06:00
Yen Chi Hsuan
c827d4cfdb
[xattr] Enhanced error messages on Windows
2015-05-14 16:53:10 +08:00
Yen Chi Hsuan
fbff30d2db
[xattr] Catch 'Argument list too long'
2015-05-14 14:51:00 +08:00
Yen Chi Hsuan
86c7fdb17c
[xattr] Enhance error handling to catch ENOSPC
...
Fixes #5589
2015-05-14 14:28:41 +08:00
Yen Chi Hsuan
2cc6d13547
[postprocessor/embedthumbnail] Encode arguments in calling AtomicParsley
2015-05-14 04:41:30 +08:00
Yen Chi Hsuan
bb8ca1d112
[postprocessor/embedthumbnail] Use run_ffmpeg_multiple_files
2015-05-14 02:35:28 +08:00
Yen Chi Hsuan
8e59539752
[postprocessor/embedthumbnail] Use thumbnails downloaded by YoutubeDL
2015-05-14 02:32:00 +08:00
Sergey M․
13763ce599
[postprocessor/ffmpeg] Add can_merge
method
2015-05-11 02:00:31 +06:00
Sergey M․
70484b9f8a
[postprocessor/ffmpeg] Extract check_outdated
method
2015-05-11 00:26:39 +06:00
Jaime Marquínez Ferrándiz
69b46b3d95
ExecAfterDownloadPP: fix __init__ method
2015-05-10 17:47:49 +02:00
Jaime Marquínez Ferrándiz
95c5534f8e
ExecAfterDownloadPP, YoutubeDL: remove unused parameters
2015-05-10 17:41:11 +02:00
Nikoli
083c1bb960
Add ability to embed subtitles in mkv files ( closes #5434 )
2015-05-01 11:54:40 +02:00
pulpe
2a09c1b8ab
[postprocessor/embedthumbnail] Fix mp3 embedding with avconv ( fixes #5526 )
2015-04-25 20:41:15 +02:00
Yen Chi Hsuan
bf6427d2fb
[ffmpeg] Add dfxp (TTML) subtitles support ( #3432 , #5146 )
2015-04-25 23:18:27 +08:00
Jaime Marquínez Ferrándiz
92995e6265
[postprocessor/embedthumbnail] Style fix
2015-04-24 22:08:00 +02:00
pulpe
10fb7710e8
Forgot to clean the remains of class
2015-04-24 09:17:46 +02:00
pulpe
c0ea8ebb9b
[ffmpeg] Remove unneeded class
2015-04-24 09:11:39 +02:00
pulpe
31fd9c7601
[embedthumbnail] use FFmpegPostProcessor for mp3
2015-04-24 09:08:57 +02:00
pulpe
ddbed36455
[embedthumbnail] Add support for mp3 cover embedding
2015-04-24 08:48:49 +02:00
Sergey M․
4515cb43ca
[xattrpp] Fix typo
2015-04-23 22:11:09 +06:00
Yen Chi Hsuan
8c8826176d
[xattr] Add version detection for python-pyxattr
...
For more information, see #5498 and changes to convertObj() in
iustin/pyxattr@cc84e466f6
2015-04-23 13:50:44 +08:00
Jaime Marquínez Ferrándiz
5b5fbc0867
Detect already merged videos
...
Without the '--keep-video' option the two files would be downloaded again and even using the option, ffmpeg would be run again, which for some videos can take a long time.
We use a temporary file with ffmpeg so that the final file only exists if it success
2015-04-19 17:51:41 +02:00
Jaime Marquínez Ferrándiz
d47aeb2252
FFmpegMergerPP: use the new system for specifying which files can be delete
2015-04-18 11:52:36 +02:00
Jaime Marquínez Ferrándiz
14523ed969
FFmpegEmbedSubtitlePP: remove the subtitle files if '--keep-video' is not given ( closes #5435 )
2015-04-18 11:44:42 +02:00
Jaime Marquínez Ferrándiz
592e97e855
Postprocessors: use a list for the files that can be deleted
...
We could only know if we had to delete the original file, but this system allows to specify us more files (like subtitles).
2015-04-18 11:36:42 +02:00
Jaime Marquínez Ferrándiz
ce81b1411d
FFmpegExtractAudioPP: Simplify handling of already existing files
2015-04-17 22:37:27 +02:00
Jaime Marquínez Ferrándiz
37b44fe7c1
[postprocessor/atomicparsley] Don't try to remove the temporary and original files if the format is unsupported ( fixes #5419 )
2015-04-13 22:50:40 +02:00
Sergey M․
dd29eb7f81
[postprocessor/common:postprocessor/ffmpeg] Generalize utime
2015-04-08 21:40:31 +06:00
Pete Hemery
cc55d08832
[ffmpeg] adding exception catching for call to os.utime in run_ffmpeg_multiple_files
2015-04-07 22:33:18 +01:00
Jaime Marquínez Ferrándiz
3da4b31359
[postprocessor/ffmpeg] Fix crash when ffprobe/avprobe are not installed ( closes #5349 )
...
'self.probe_basename' was None, so 'probe_executable' raised a KeyError exception
2015-04-03 14:09:50 +02:00
Jaime Marquínez Ferrándiz
70a1165b32
Don't use bare 'except:'
...
They catch any exception, including KeyboardInterrupt, we don't want to catch it.
2015-03-27 13:02:20 +01:00
Jaime Marquínez Ferrándiz
88cf6fb368
[metadatafromtitle] Some improvements and cleanup
...
* Remove the 'songtitle' field, 'title' can be used instead.
* Remove newlines in the help text, for consistency with other options.
* Add 'from __future__ import unicode_literals'.
* Call '__init__' from the parent class.
* Add test for the format_to_regex method
2015-03-14 20:06:33 +01:00
phiresky
e7db87f700
Add metadata from title parser
...
(Closes #5125 )
2015-03-14 19:46:22 +01:00
Jaime Marquínez Ferrándiz
e9fade72f3
Add postprocessor for converting subtitles ( closes #4954 )
2015-02-28 14:43:24 +01:00
Jaime Marquínez Ferrándiz
bfc993cc91
Merge branch 'subtitles-rework'
...
(Closes PR #4964 )
2015-02-23 17:13:03 +01:00
Philipp Hagemeister
65bf37ef83
[ffmpeg] Remove trivial helper method
2015-02-17 17:27:29 +01:00
Philipp Hagemeister
f740fae2a4
[ffmpeg] Make available a property
2015-02-17 17:26:41 +01:00
Jaime Marquínez Ferrándiz
c84dd8a90d
[YoutubeDL] store the subtitles to download in the 'requested_subtitles' field
...
We need to keep the orginal subtitles information, so that the '--load-info' option can be used to list or select the subtitles again.
We'll also be able to have a separate field for storing the automatic captions info.
2015-02-16 21:51:08 +01:00
Jaime Marquínez Ferrándiz
a504ced097
Improve subtitles support
...
For each language the extractor builds a list with the available formats sorted (like for video formats), then YoutubeDL selects one of them using the '--sub-format' option which now allows giving the format preferences (for example 'ass/srt/best').
For each format the 'url' field can be set so that we only download the contents if needed, or if the contents needs to be processed (like in crunchyroll) the 'data' field can be used.
The reasons for this change are:
* We weren't checking that the format given with '--sub-format' was available, checking it in each extractor would be repetitive.
* It allows to easily support giving a format preference.
* The subtitles were automatically downloaded in the extractor, but I think that if you use for example the '--dump-json' option you want to finish as fast as possible.
Currently only the ted extractor has been updated, but the old system still works.
2015-02-16 21:51:03 +01:00
Philipp Hagemeister
5bfd430f81
Merge remote-tracking branch 'origin/master'
2015-02-16 04:09:10 +01:00
Philipp Hagemeister
73fac4e911
[ffmpeg] Add --ffmpeg-location
2015-02-16 04:05:53 +01:00
Jaime Marquínez Ferrándiz
cffcbc02de
[postprocessor/ffmpeg] Don't let ffmpeg read from stdin ( fixes #4945 )
...
If you run 'while read aurl ; do youtube-dl --extract-audio "${aurl}"; done < path_to_batch_file' (batch_file contains one url per line) each call to youtube-dl consumed some characters and 'read' would assing to 'aurl' a non valid url, something like 'tube.com/watch?v=<id>'.
2015-02-13 22:25:34 +01:00
Jaime Marquínez Ferrándiz
467d3c9a0c
[ffmpeg] --extrac-audio: Use the same options for avconv and ffmpeg
...
They have been available in ffmpeg since version 0.9, and we require 1.0 or higher.
2015-02-06 22:05:11 +01:00
Philipp Hagemeister
2cf0ecac7b
[ffmpeg] --add-metadata: Set comment and purl fields ( Fixes #4847 )
2015-02-03 00:16:45 +01:00
Philipp Hagemeister
62cd676c74
[youtube] Fixup DASH m4a headers
...
This fixes #2288 , #2506 , #2607 , #3681 , #4741 , #4767 .
2015-01-23 18:39:12 +01:00
David Powell
bd3cbe0716
Embed description and URL as MP4 tags
2015-01-18 15:01:05 -08:00
Jaime Marquínez Ferrándiz
2875cf01bb
FFmpegEmbedSubtitlePP: simplify command
2015-01-16 13:37:37 +01:00
Jaime Marquínez Ferrándiz
e205db3bcd
FFmpegEmbedSubtitlePP: don't fail if the video doesn't have an audio stream ( fixes #4718 )
...
Instead of specifying which streams ffmpeg must copy, we tell it to copy all.
2015-01-16 13:29:01 +01:00
Philipp Hagemeister
52afb2ac1b
[ffmpeg] Call encodeFilename on filenames
2015-01-10 06:13:18 +01:00
Philipp Hagemeister
43bc88903d
Merge remote-tracking branch 'ivan/muxed-mtime'
2015-01-10 06:10:18 +01:00
Philipp Hagemeister
6271f1cad9
[youtube|ffmpeg] Automatically correct video with non-square pixels ( Fixes #4674 )
2015-01-10 05:45:51 +01:00
Philipp Hagemeister
b0e87c3110
[ffmpeg] Correctly encode paths on Windows
...
On Python 2.x on Windows, if there are any unicode arguments in the command argument list, the whole list is converted to unicode internally.
Therefore, we need to call encodeArgument on every argument.
Fixes #4337 and #4668 .
2015-01-09 19:02:07 +01:00
Jaime Marquínez Ferrándiz
bc3e582fe4
Don't use '-shortest' option for merging formats ( closes #4220 , closes #4580 )
...
With avconv and older versions of ffmpeg the video is partially copied.
The duration difference between the audio and the video seem to be really small, so it's probably not noticeable.
2015-01-04 14:02:17 +01:00
Philipp Hagemeister
4f026fafbc
[YoutubeDL] Make postprocessors declarative
...
Instead of having to configure PPs in code, this allows us and embedding programs not to worry about imports or finer details, similarly to how we handle IEs.
2014-12-15 01:06:25 +01:00
Jaime Marquínez Ferrándiz
83e865a370
Fix PEP8 issue E713
2014-12-09 23:11:26 +01:00