From ce7fa2423b7800b95ec9f94917e86736c0e09d01 Mon Sep 17 00:00:00 2001 From: teddy171 Date: Wed, 8 Feb 2023 07:05:52 +0800 Subject: [PATCH] Apply suggestions from code review Co-authored-by: dirkf --- test/test_external_downloader.py | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/test/test_external_downloader.py b/test/test_external_downloader.py index 6295b8cd0..8dda6d99b 100644 --- a/test/test_external_downloader.py +++ b/test/test_external_downloader.py @@ -31,8 +31,7 @@ class HTTPTestRequestHandler(compat_http_server.BaseHTTPRequestHandler): if range_header: mobj = re.match(r'bytes=(\d+)-(\d+)', range_header) if mobj: - start = int(mobj.group(1)) - end = int(mobj.group(2)) + start, end = (int(mobj.group(i)) for i in (1, 2)) valid_range = start is not None and end is not None if valid_range: content_range = 'bytes %d-%d' % (start, end) @@ -62,7 +61,7 @@ class HTTPTestRequestHandler(compat_http_server.BaseHTTPRequestHandler): elif self.path == '/no-range-no-content-length': self.serve(range=False, content_length=False) else: - assert False + assert False, 'unrecognised server path' class FakeLogger(object):