From f2b0d01274d72419af340dd42bfa35397383ef5d Mon Sep 17 00:00:00 2001 From: df Date: Wed, 27 Oct 2021 12:38:58 +0100 Subject: [PATCH 1/2] Remove syntactically incorrect and redundant case Now passes shellcheck.net! --- devscripts/run_tests.sh | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/devscripts/run_tests.sh b/devscripts/run_tests.sh index dd37a80f5..d83ebcdbd 100755 --- a/devscripts/run_tests.sh +++ b/devscripts/run_tests.sh @@ -14,9 +14,7 @@ case "$YTDL_TEST_SET" in test_set="-I test_(?!$DOWNLOAD_TESTS).+\.py" multiprocess_args="--processes=4 --process-timeout=540" ;; - *) - break - ;; esac +# shellcheck disable=SC2086 nosetests test --verbose $test_set $multiprocess_args From 7f5ea5a28c34b6356884d076ef74331c6eb64026 Mon Sep 17 00:00:00 2001 From: df Date: Wed, 27 Oct 2021 12:43:59 +0100 Subject: [PATCH 2/2] Avoid masking errors with `export var=val` Now passes shellcheck.net! --- devscripts/wine-py2exe.sh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/devscripts/wine-py2exe.sh b/devscripts/wine-py2exe.sh index dc2d6501a..cb175e23a 100755 --- a/devscripts/wine-py2exe.sh +++ b/devscripts/wine-py2exe.sh @@ -14,7 +14,7 @@ if [ ! -d wine-py2exe ]; then mkdir wine-py2exe cd wine-py2exe - export WINEPREFIX=`pwd` + WINEPREFIX=$(pwd); export WINEPREFIX axel -a "http://www.python.org/ftp/python/2.7/python-2.7.msi" axel -a "http://downloads.sourceforge.net/project/py2exe/py2exe/0.6.9/py2exe-0.6.9.win32-py2.7.exe" @@ -45,7 +45,7 @@ if [ ! -d wine-py2exe ]; then else - export WINEPREFIX="$( cd wine-py2exe && pwd )" + WINEPREFIX=$( cd wine-py2exe && pwd ); export WINEPREFIX fi