From 34df2cd4b727ac1c460a6342d155bbd88dcb9c52 Mon Sep 17 00:00:00 2001 From: Camille Flynn Date: Wed, 2 Nov 2022 10:45:21 +0100 Subject: [PATCH 1/2] Clarify: playlist-start/end options are inclusive Edit the README.md and the help text to clarify that the number specified for the --playlist-start and --playlist-end options when downloading a playlist is inclusive --- README.md | 4 ++-- youtube_dl/options.py | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/README.md b/README.md index cd888c731..4651557fe 100644 --- a/README.md +++ b/README.md @@ -128,9 +128,9 @@ Alternatively, refer to the [developer instructions](#developer-instructions) fo CIDR notation ## Video Selection: - --playlist-start NUMBER Playlist video to start at (default is + --playlist-start NUMBER Playlist video to start at (inclusive) (default is 1) - --playlist-end NUMBER Playlist video to end at (default is + --playlist-end NUMBER Playlist video to end at (inclusive) (default is last) --playlist-items ITEM_SPEC Playlist video items to download. Specify indices of the videos in the diff --git a/youtube_dl/options.py b/youtube_dl/options.py index f6d2b0898..0fb447090 100644 --- a/youtube_dl/options.py +++ b/youtube_dl/options.py @@ -258,11 +258,11 @@ def parseOpts(overrideArguments=None): selection.add_option( '--playlist-start', dest='playliststart', metavar='NUMBER', default=1, type=int, - help='Playlist video to start at (default is %default)') + help='Playlist video to start at (inclusive) (default is %default)') selection.add_option( '--playlist-end', dest='playlistend', metavar='NUMBER', default=None, type=int, - help='Playlist video to end at (default is last)') + help='Playlist video to end at (inclusive) (default is last)') selection.add_option( '--playlist-items', dest='playlist_items', metavar='ITEM_SPEC', default=None, From b8d6126d30f390f9c968738de2ca549c51c69c87 Mon Sep 17 00:00:00 2001 From: Camille Flynn <116341957+camilleflynn@users.noreply.github.com> Date: Wed, 21 Jun 2023 20:16:43 +0000 Subject: [PATCH 2/2] Improve wording (apply suggestions from code review) Co-authored-by: dirkf --- README.md | 8 ++++---- youtube_dl/options.py | 4 ++-- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/README.md b/README.md index 4651557fe..5cf76c8ef 100644 --- a/README.md +++ b/README.md @@ -128,10 +128,10 @@ Alternatively, refer to the [developer instructions](#developer-instructions) fo CIDR notation ## Video Selection: - --playlist-start NUMBER Playlist video to start at (inclusive) (default is - 1) - --playlist-end NUMBER Playlist video to end at (inclusive) (default is - last) + --playlist-start NUMBER Playlist index of first item to include (default + is 1) + --playlist-end NUMBER Playlist index of last item to include (default + is last) --playlist-items ITEM_SPEC Playlist video items to download. Specify indices of the videos in the playlist separated by commas like: "-- diff --git a/youtube_dl/options.py b/youtube_dl/options.py index 0fb447090..01638b6f1 100644 --- a/youtube_dl/options.py +++ b/youtube_dl/options.py @@ -258,11 +258,11 @@ def parseOpts(overrideArguments=None): selection.add_option( '--playlist-start', dest='playliststart', metavar='NUMBER', default=1, type=int, - help='Playlist video to start at (inclusive) (default is %default)') + help='Playlist index of first item to include (default is %default)') selection.add_option( '--playlist-end', dest='playlistend', metavar='NUMBER', default=None, type=int, - help='Playlist video to end at (inclusive) (default is last)') + help='Playlist index of last item to include (default is last)') selection.add_option( '--playlist-items', dest='playlist_items', metavar='ITEM_SPEC', default=None,