From 45fd630e1a7061265c08dbb803ae4b2750e03892 Mon Sep 17 00:00:00 2001 From: shibafu Date: Wed, 12 Aug 2020 22:05:49 +0900 Subject: [PATCH] fix test --- database/factories/ContentProviderFactory.php | 14 ++++++++++++++ .../Unit/Services/MetadataResolverServiceTest.php | 3 +++ 2 files changed, 17 insertions(+) create mode 100644 database/factories/ContentProviderFactory.php diff --git a/database/factories/ContentProviderFactory.php b/database/factories/ContentProviderFactory.php new file mode 100644 index 0000000..097f635 --- /dev/null +++ b/database/factories/ContentProviderFactory.php @@ -0,0 +1,14 @@ +define(ContentProvider::class, function (Faker $faker) { + return [ + 'host' => 'example.com', + 'robots' => null, + 'robots_cached_at' => now(), + ]; +}); diff --git a/tests/Unit/Services/MetadataResolverServiceTest.php b/tests/Unit/Services/MetadataResolverServiceTest.php index d8c7528..000d33d 100644 --- a/tests/Unit/Services/MetadataResolverServiceTest.php +++ b/tests/Unit/Services/MetadataResolverServiceTest.php @@ -2,6 +2,7 @@ namespace Tests\Unit\Services; +use App\ContentProvider; use App\MetadataResolver\MetadataResolver; use App\MetadataResolver\ResolverCircuitBreakException; use App\MetadataResolver\UncaughtResolverException; @@ -26,6 +27,8 @@ class MetadataResolverServiceTest extends TestCase parent::setUp(); $this->seed(); Carbon::setTestNow('2020-07-21 19:19:19'); + // FIXME: 今書かれてるテストはresolveのHTTPリクエストのみを考慮しているので、ContentProviderにデータがないとリクエスト回数がずれる + factory(ContentProvider::class)->create(); } protected function tearDown(): void