From 116dd3b798206eae4ffebb7f8318eca71e86b08e Mon Sep 17 00:00:00 2001 From: unarist Date: Tue, 12 Feb 2019 22:45:51 +0900 Subject: [PATCH] =?UTF-8?q?OGPResolver=E3=81=A7meta[name=3D"description"]?= =?UTF-8?q?=20=E3=81=AB=E3=83=95=E3=82=A9=E3=83=BC=E3=83=AB=E3=83=90?= =?UTF-8?q?=E3=83=83=E3=82=AF=E3=81=99=E3=82=8B=F0=9F=90=AF=20(#91)?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- app/MetadataResolver/OGPResolver.php | 2 +- tests/Unit/MetadataResolver/OGPResolverTest.php | 15 +++++++++++++++ 2 files changed, 16 insertions(+), 1 deletion(-) diff --git a/app/MetadataResolver/OGPResolver.php b/app/MetadataResolver/OGPResolver.php index 3002d91..1cf4c1e 100644 --- a/app/MetadataResolver/OGPResolver.php +++ b/app/MetadataResolver/OGPResolver.php @@ -30,7 +30,7 @@ class OGPResolver implements Resolver, Parser $metadata->title = $nodes->item(0)->textContent; } } - $metadata->description = $this->findContent($xpath, '//meta[@*="og:description"]', '//meta[@*="twitter:description"]'); + $metadata->description = $this->findContent($xpath, '//meta[@*="og:description"]', '//meta[@*="twitter:description"]', '//meta[@name="description"]'); $metadata->image = $this->findContent($xpath, '//meta[@*="og:image"]', '//meta[@*="twitter:image"]'); return $metadata; diff --git a/tests/Unit/MetadataResolver/OGPResolverTest.php b/tests/Unit/MetadataResolver/OGPResolverTest.php index fd9375f..1befcd0 100644 --- a/tests/Unit/MetadataResolver/OGPResolverTest.php +++ b/tests/Unit/MetadataResolver/OGPResolverTest.php @@ -35,4 +35,19 @@ class OGPResolverTest extends TestCase $this->assertEmpty($metadata->description); $this->assertEmpty($metadata->image); } + + public function testResolveTitleAndDescription() + { + $resolver = new OGPResolver(); + + $html = <<Welcome to my homepage + +EOF; + + $metadata = $resolver->parse($html); + $this->assertEquals('Welcome to my homepage', $metadata->title); + $this->assertEquals('This is my super hyper ultra homepage!!', $metadata->description); + $this->assertEmpty($metadata->image); + } }