mirror of
https://github.com/brain-hackers/u-boot-brain
synced 2024-08-22 18:09:03 +09:00
![Marek Vasut](/assets/img/avatar_default.png)
The GPIO driver didn't correctly compute the bank offset from the GPIO number and caused random writes into the GPIO block address space. Fix the driver so it actually does the writes correctly. While at it, make use of the clrsetbits_le32() mechanisms. Signed-off-by: Marek Vasut <marex@denx.de> Cc: Kyungmin Park <kyungmin.park@samsung.com> Cc: Lukasz Majewski <l.majewski@samsung.com> Cc: Minkyu Kang <mk7.kang@samsung.com> Cc: Vladimir Zapolskiy <vz@mleia.com> Signed-off-by: Minkyu Kang <mk7.kang@samsung.com>
89 lines
1.7 KiB
C
89 lines
1.7 KiB
C
/*
|
|
* Copyright (C) 2012
|
|
* Gabriel Huau <contact@huau-gabriel.fr>
|
|
*
|
|
* SPDX-License-Identifier: GPL-2.0+
|
|
*/
|
|
#include <common.h>
|
|
#include <asm/arch/s3c2440.h>
|
|
#include <asm/gpio.h>
|
|
#include <asm/io.h>
|
|
#include <errno.h>
|
|
|
|
#define GPIO_INPUT 0x0
|
|
#define GPIO_OUTPUT 0x1
|
|
|
|
#define S3C_GPIO_CON 0x0
|
|
#define S3C_GPIO_DAT 0x4
|
|
|
|
static uint32_t s3c_gpio_get_bank_addr(unsigned gpio)
|
|
{
|
|
/* There is up to 16 pins per bank, one bank is 0x10 big. */
|
|
uint32_t addr = gpio & ~0xf;
|
|
|
|
if (addr >= 0x80 && addr != 0xd0) { /* Wrong GPIO bank. */
|
|
printf("Invalid GPIO bank (bank %02x)\n", addr);
|
|
return 0xffffffff;
|
|
}
|
|
|
|
return addr | S3C24X0_GPIO_BASE;
|
|
}
|
|
|
|
int gpio_set_value(unsigned gpio, int value)
|
|
{
|
|
uint32_t addr = s3c_gpio_get_bank_addr(gpio);
|
|
|
|
if (addr == 0xffffffff)
|
|
return -EINVAL;
|
|
|
|
if (value)
|
|
setbits_le32(addr | S3C_GPIO_DAT, 1 << (gpio & 0xf));
|
|
else
|
|
clrbits_le32(addr | S3C_GPIO_DAT, 1 << (gpio & 0xf));
|
|
|
|
return 0;
|
|
}
|
|
|
|
int gpio_get_value(unsigned gpio)
|
|
{
|
|
uint32_t addr = s3c_gpio_get_bank_addr(gpio);
|
|
|
|
if (addr == 0xffffffff)
|
|
return -EINVAL;
|
|
|
|
return !!(readl(addr | S3C_GPIO_DAT) & (1 << (gpio & 0xf)));
|
|
}
|
|
|
|
int gpio_request(unsigned gpio, const char *label)
|
|
{
|
|
return 0;
|
|
}
|
|
|
|
int gpio_free(unsigned gpio)
|
|
{
|
|
return 0;
|
|
}
|
|
|
|
static int s3c_gpio_direction(unsigned gpio, uint8_t dir)
|
|
{
|
|
uint32_t addr = s3c_gpio_get_bank_addr(gpio);
|
|
const uint32_t mask = 0x3 << ((gpio & 0xf) << 1);
|
|
const uint32_t dirm = dir << ((gpio & 0xf) << 1);
|
|
|
|
if (addr == 0xffffffff)
|
|
return -EINVAL;
|
|
|
|
clrsetbits_le32(addr | S3C_GPIO_CON, mask, dirm);
|
|
return 0;
|
|
}
|
|
|
|
int gpio_direction_input(unsigned gpio)
|
|
{
|
|
return s3c_gpio_direction(gpio, GPIO_INPUT);
|
|
}
|
|
|
|
int gpio_direction_output(unsigned gpio, int value)
|
|
{
|
|
return s3c_gpio_direction(gpio, GPIO_OUTPUT);
|
|
}
|