mirror of
https://github.com/brain-hackers/u-boot-brain
synced 2024-06-09 23:36:03 +09:00
b75d8dc564
The Linux coding style guide (Documentation/process/coding-style.rst) clearly says: It's a **mistake** to use typedef for structures and pointers. Besides, using typedef for structures is annoying when you try to make headers self-contained. Let's say you have the following function declaration in a header: void foo(bd_t *bd); This is not self-contained since bd_t is not defined. To tell the compiler what 'bd_t' is, you need to include <asm/u-boot.h> #include <asm/u-boot.h> void foo(bd_t *bd); Then, the include direcective pulls in more bloat needlessly. If you use 'struct bd_info' instead, it is enough to put a forward declaration as follows: struct bd_info; void foo(struct bd_info *bd); Right, typedef'ing bd_t is a mistake. I used coccinelle to generate this commit. The semantic patch that makes this change is as follows: <smpl> @@ typedef bd_t; @@ -bd_t +struct bd_info </smpl> Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
23 lines
583 B
C
23 lines
583 B
C
/* SPDX-License-Identifier: GPL-2.0+ */
|
|
/*
|
|
* Copyright 2019-2020 NXP
|
|
*
|
|
* PCIe DT fixup for NXP Layerscape SoCs
|
|
* Author: Wasim Khan <wasim.khan@nxp.com>
|
|
*
|
|
*/
|
|
#ifndef _PCIE_LAYERSCAPE_FIXUP_COMMON_H_
|
|
#define _PCIE_LAYERSCAPE_FIXUP_COMMON_H_
|
|
|
|
#include <common.h>
|
|
|
|
void ft_pci_setup_ls(void *blob, struct bd_info *bd);
|
|
|
|
#ifdef CONFIG_PCIE_LAYERSCAPE_GEN4
|
|
void ft_pci_setup_ls_gen4(void *blob, struct bd_info *bd);
|
|
#endif /* CONFIG_PCIE_LAYERSCAPE_GEN4 */
|
|
int pcie_next_streamid(int currentid, int id);
|
|
int pcie_board_fix_fdt(void *fdt);
|
|
|
|
#endif //_PCIE_LAYERSCAPE_FIXUP_COMMON_H_
|