mirror of
https://github.com/brain-hackers/u-boot-brain
synced 2024-08-15 06:33:45 +09:00
![]() The hush shell dynamically allocates (and re-allocates) memory for the argument strings in the "char *argv[]" argument vector passed to commands. Any code that modifies these pointers will cause serious corruption of the malloc data structures and crash U-Boot, so make sure the compiler can check that no such modifications are being done by changing the code into "char * const argv[]". This modification is the result of debugging a strange crash caused after adding a new command, which used the following argument processing code which has been working perfectly fine in all Unix systems since version 6 - but not so in U-Boot: int main (int argc, char **argv) { while (--argc > 0 && **++argv == '-') { /* ====> */ while (*++*argv) { switch (**argv) { case 'd': debug++; break; ... default: usage (); } } } ... } The line marked "====>" will corrupt the malloc data structures and usually cause U-Boot to crash when the next command gets executed by the shell. With the modification, the compiler will prevent this with an error: increment of read-only location '*argv' N.B.: The code above can be trivially rewritten like this: while (--argc > 0 && **++argv == '-') { char *arg = *argv; while (*++arg) { switch (*arg) { ... Signed-off-by: Wolfgang Denk <wd@denx.de> Acked-by: Mike Frysinger <vapier@gentoo.org> |
||
---|---|---|
.. | ||
uImage.FIT | ||
feature-removal-schedule.txt | ||
I2C_Edge_Conditions | ||
README-i386 | ||
README-integrator | ||
README.440-DDR-performance | ||
README.alaska8220 | ||
README.AMCC-eval-boards-cleanup | ||
README.amigaone | ||
README.ARM-memory-map | ||
README.ARM-SoC | ||
README.at91 | ||
README.at91-soc | ||
README.atum8548 | ||
README.autoboot | ||
README.AVR32 | ||
README.AVR32-port-muxing | ||
README.bamboo | ||
README.bedbug | ||
README.bitbangMII | ||
README.blackfin | ||
README.bus_vcxk | ||
README.cmi | ||
README.COBRA5272 | ||
README.commands | ||
README.commands.itest | ||
README.console | ||
README.davinci | ||
README.db64360 | ||
README.db64460 | ||
README.dns | ||
README.drivers.eth | ||
README.ebony | ||
README.enetaddr | ||
README.evb64260 | ||
README.EVB-64260-750CX | ||
README.fads | ||
README.fsl-ddr | ||
README.generic_usb_ohci | ||
README.hwconfig | ||
README.IceCube | ||
README.idma2intr | ||
README.imx31 | ||
README.imximage | ||
README.INCA-IP | ||
README.iomux | ||
README.IPHASE4539 | ||
README.JFFS2 | ||
README.JFFS2_NAND | ||
README.kmeter1 | ||
README.korat | ||
README.kwbimage | ||
README.LED | ||
README.Lite5200B_low_power | ||
README.lynxkdi | ||
README.m68k | ||
README.m5253evbe | ||
README.m5373evb | ||
README.m5475evb | ||
README.m52277evb | ||
README.m53017evb | ||
README.m54455evb | ||
README.marubun-pcmcia | ||
README.MBX | ||
README.mflash | ||
README.mips | ||
README.Modem | ||
README.modnet50 | ||
README.mpc5xx | ||
README.mpc74xx | ||
README.mpc83xx.ddrecc | ||
README.mpc83xxads | ||
README.mpc85xxads | ||
README.mpc85xxcds | ||
README.mpc832xemds | ||
README.mpc837xemds | ||
README.mpc837xerdb | ||
README.mpc7448hpc2 | ||
README.mpc8313erdb | ||
README.mpc8315erdb | ||
README.mpc8323erdb | ||
README.mpc8349itx | ||
README.mpc8360emds | ||
README.mpc8536ds | ||
README.mpc8544ds | ||
README.mpc8569mds | ||
README.mpc8572ds | ||
README.mpc8610hpcd | ||
README.mpc8641hpcn | ||
README.MPC866 | ||
README.mvbc_p | ||
README.mvblm7 | ||
README.mvsmr | ||
README.nand | ||
README.nand-boot-ppc440 | ||
README.ne2000 | ||
README.NetConsole | ||
README.nhk8815 | ||
README.ns9750dev | ||
README.ocotea | ||
README.ocotea-PIBS-to-U-Boot | ||
README.OFT | ||
README.omap3 | ||
README.omap730p2 | ||
README.OXC | ||
README.p2020rdb | ||
README.phytec.pcm030 | ||
README.PIP405 | ||
README.PlanetCore | ||
README.POST | ||
README.ppc440 | ||
README.Purple | ||
README.PXA_CF | ||
README.qemu_mips | ||
README.RPXClassic | ||
README.RPXlite | ||
README.s5pc1xx | ||
README.Sandpoint8240 | ||
README.sata | ||
README.sbc8349 | ||
README.sbc8548 | ||
README.sbc8641d | ||
README.SBC8560 | ||
README.sched | ||
README.serial_multi | ||
README.sh | ||
README.sh7785lcr | ||
README.sha1 | ||
README.silent | ||
README.simpc8313 | ||
README.SNTP | ||
README.spear | ||
README.standalone | ||
README.stxxtc | ||
README.timll | ||
README.TQM8260 | ||
README.update | ||
README.usb | ||
README.video | ||
README.VLAN | ||
README.xpedite1k | ||
README.zeus | ||
TODO-i386 |
Storage of the board specific values (ethaddr...) ------------------------------------------------- The board specific environment variables that should be unique for each individual board, can be stored in the I2C EEPROM. This will be done from offset 0x80 with the length of 0x80 bytes. The following command can be used to store the values here: => setdef de:20:6a:ed:e2:72 de:20:6a:ed:e2:73 AB0001 ethaddr eth1addr serial# Now those 3 values are stored into the I2C EEPROM. A CRC is added to make sure that the values get not corrupted. SW-Reset Pushbutton handling: ----------------------------- The SW-reset push button is connected to a GPIO input too. This way U-Boot can "see" how long the SW-reset was pressed, and a specific action can be taken. Two different actions are supported: a) Release after more than 5 seconds and less then 10 seconds: -> Run POST Please note, that the POST test will take a while (approx. 1 min on the 128MByte board). This is mainly due to the system memory test. b) Release after more than 10 seconds: -> Restore factory default settings The factory default values are restored. The default environment variables are restored (ipaddr, serverip...) and the board specific values (ethaddr, eth1addr and serial#) are restored to the environment from the I2C EEPROM. Also a bootline parameter is added to the Linux bootline to signal the Linux kernel upon the next startup, that the factory defaults should be restored. The command to check this sw-reset status and act accordingly is => chkreset This command is added to the default "bootcmd", so that it is called automatically upon startup. Also, the 2 LED's are used to indicate the current status of this command (time passed since pushing the button). When the POST test will be run, the green LED will be switched off, and when the factory restore will be initiated, the reg LED will be switched off. Loggin of POST results: ----------------------- The results of the POST tests are logged in a logbuffer located at the end of the onboard memory. It can be accessed with the U-Boot command "log": => log show <4>POST memory PASSED <4>POST cache PASSED <4>POST cpu PASSED <4>POST uart PASSED <4>POST ethernet PASSED The DENX Linux kernel tree has support for this log buffer included. Exactly this buffer is used for logging of all kernel messages too. By enabling the compile time option "CONFIG_LOGBUFFER" this support is enabled. This way you can access the U-Boot log messages from Linux too. 2007-08-10, Stefan Roese <sr@denx.de>