mirror of
https://github.com/brain-hackers/u-boot-brain
synced 2024-08-17 07:28:51 +09:00
![Mateusz Kulikowski](/assets/img/avatar_default.png)
ulpi_read and ulpi_write are used to read/write registers via ULPI bus. Code generates compilation warnings on 64-bit machines where pointer is cast to u32. This patch drops all but last 8 bits of register address. It is possible, because addresses on ULPI bus are 6- or 8-bit. It is not possible (according to ULPI 1.1 spec) to have more than 8-bit addressing. This patch should not cause regressions as all calls to ulpi_read/write use either structure pointer (@ address 0) or integer offsets cast to pointer - addresses requested are way below 8-bit range. Signed-off-by: Mateusz Kulikowski <mateusz.kulikowski@gmail.com> Acked-by: Marek Vasut <marex@denx.de>
114 lines
2.3 KiB
C
114 lines
2.3 KiB
C
/*
|
|
* Copyright (C) 2011 Jana Rapava <fermata7@gmail.com>
|
|
* Copyright (C) 2011 CompuLab, Ltd. <www.compulab.co.il>
|
|
*
|
|
* Authors: Jana Rapava <fermata7@gmail.com>
|
|
* Igor Grinberg <grinberg@compulab.co.il>
|
|
*
|
|
* Based on:
|
|
* linux/drivers/usb/otg/ulpi_viewport.c
|
|
*
|
|
* Original Copyright follow:
|
|
* Copyright (C) 2011 Google, Inc.
|
|
*
|
|
* SPDX-License-Identifier: GPL-2.0
|
|
*/
|
|
|
|
#include <common.h>
|
|
#include <asm/io.h>
|
|
#include <usb/ulpi.h>
|
|
|
|
/* ULPI viewport control bits */
|
|
#define ULPI_SS (1 << 27)
|
|
#define ULPI_RWCTRL (1 << 29)
|
|
#define ULPI_RWRUN (1 << 30)
|
|
#define ULPI_WU (1 << 31)
|
|
|
|
/*
|
|
* Wait for the ULPI request to complete
|
|
*
|
|
* @ulpi_viewport - the address of the viewport
|
|
* @mask - expected value to wait for
|
|
*
|
|
* returns 0 on mask match, ULPI_ERROR on time out.
|
|
*/
|
|
static int ulpi_wait(struct ulpi_viewport *ulpi_vp, u32 mask)
|
|
{
|
|
int timeout = CONFIG_USB_ULPI_TIMEOUT;
|
|
|
|
/* Wait for the bits in mask to become zero. */
|
|
while (--timeout) {
|
|
if ((readl(ulpi_vp->viewport_addr) & mask) == 0)
|
|
return 0;
|
|
|
|
udelay(1);
|
|
}
|
|
|
|
return ULPI_ERROR;
|
|
}
|
|
|
|
/*
|
|
* Wake the ULPI PHY up for communication
|
|
*
|
|
* returns 0 on success.
|
|
*/
|
|
static int ulpi_wakeup(struct ulpi_viewport *ulpi_vp)
|
|
{
|
|
int err;
|
|
|
|
if (readl(ulpi_vp->viewport_addr) & ULPI_SS)
|
|
return 0; /* already awake */
|
|
|
|
writel(ULPI_WU, ulpi_vp->viewport_addr);
|
|
|
|
err = ulpi_wait(ulpi_vp, ULPI_WU);
|
|
if (err)
|
|
printf("ULPI wakeup timed out\n");
|
|
|
|
return err;
|
|
}
|
|
|
|
/*
|
|
* Issue a ULPI read/write request
|
|
*
|
|
* @value - the ULPI request
|
|
*/
|
|
static int ulpi_request(struct ulpi_viewport *ulpi_vp, u32 value)
|
|
{
|
|
int err;
|
|
|
|
err = ulpi_wakeup(ulpi_vp);
|
|
if (err)
|
|
return err;
|
|
|
|
writel(value, ulpi_vp->viewport_addr);
|
|
|
|
err = ulpi_wait(ulpi_vp, ULPI_RWRUN);
|
|
if (err)
|
|
printf("ULPI request timed out\n");
|
|
|
|
return err;
|
|
}
|
|
|
|
int ulpi_write(struct ulpi_viewport *ulpi_vp, u8 *reg, u32 value)
|
|
{
|
|
u32 addr = (uintptr_t)reg & 0xFF;
|
|
u32 val = ULPI_RWRUN | ULPI_RWCTRL | addr << 16 | (value & 0xff);
|
|
|
|
val |= (ulpi_vp->port_num & 0x7) << 24;
|
|
return ulpi_request(ulpi_vp, val);
|
|
}
|
|
|
|
u32 ulpi_read(struct ulpi_viewport *ulpi_vp, u8 *reg)
|
|
{
|
|
int err;
|
|
u32 val = ULPI_RWRUN | ((uintptr_t)reg & 0xFF) << 16;
|
|
|
|
val |= (ulpi_vp->port_num & 0x7) << 24;
|
|
err = ulpi_request(ulpi_vp, val);
|
|
if (err)
|
|
return err;
|
|
|
|
return (readl(ulpi_vp->viewport_addr) >> 8) & 0xff;
|
|
}
|