mirror of
https://github.com/brain-hackers/u-boot-brain
synced 2024-09-03 03:13:21 +09:00
![Yasushi SHOJI](/assets/img/avatar_default.png)
Without the volatile attribute, compilers are entitled to optimize out the same asm(). In the case of __udelay() in syscounter.c, it calls `get_ticks()` twice, one for the starting time and the second in the loop to check the current time. When compilers inline `get_ticks()` they see the same `mrrc` instructions and optimize out the second one. This leads to infinite loop since we don't get updated value from the system counter. Here is a portion of the disassembly of __udelay: 88: 428b cmp r3, r1 8a: f8ce 20a4 str.w r2, [lr, #164] ; 0xa4 8e: bf08 it eq 90: 4282 cmpeq r2, r0 92: f8ce 30a0 str.w r3, [lr, #160] ; 0xa0 96: d3f7 bcc.n 88 <__udelay+0x88> 98: e8bd 8cf0 ldmia.w sp!, {r4, r5, r6, r7, sl, fp, pc} Note that final jump / loop at 96 to 88, we don't have any `mrrc`. With a volatile attribute, the above changes to this: 8a: ec53 2f0e mrrc 15, 0, r2, r3, cr14 8e: 42ab cmp r3, r5 90: f8c1 20a4 str.w r2, [r1, #164] ; 0xa4 94: bf08 it eq 96: 42a2 cmpeq r2, r4 98: f8c1 30a0 str.w r3, [r1, #160] ; 0xa0 9c: d3f5 bcc.n 8a <__udelay+0x8a> 9e: e8bd 8cf0 ldmia.w sp!, {r4, r5, r6, r7, sl, fp, pc} a2: bf00 nop I'm advised[1] to put volatile on all asm(), so this commit also adds it to the asm() in timer_init(). [1]: https://lists.denx.de/pipermail/u-boot/2018-March/322062.html Signed-off-by: Yasushi SHOJI <yasushi.shoji@gmail.com> Reviewed-by: Fabio Estevam <fabio.estevam@nxp.com>
127 lines
2.4 KiB
C
127 lines
2.4 KiB
C
/*
|
|
* Copyright (C) 2015 Freescale Semiconductor, Inc.
|
|
*
|
|
* SPDX-License-Identifier: GPL-2.0+
|
|
*
|
|
* The file use ls102xa/timer.c as a reference.
|
|
*/
|
|
|
|
#include <common.h>
|
|
#include <asm/io.h>
|
|
#include <div64.h>
|
|
#include <asm/arch/imx-regs.h>
|
|
#include <asm/arch/sys_proto.h>
|
|
#include <asm/mach-imx/syscounter.h>
|
|
|
|
DECLARE_GLOBAL_DATA_PTR;
|
|
|
|
/*
|
|
* This function is intended for SHORT delays only.
|
|
* It will overflow at around 10 seconds @ 400MHz,
|
|
* or 20 seconds @ 200MHz.
|
|
*/
|
|
unsigned long usec2ticks(unsigned long usec)
|
|
{
|
|
ulong ticks;
|
|
|
|
if (usec < 1000)
|
|
ticks = ((usec * (get_tbclk()/1000)) + 500) / 1000;
|
|
else
|
|
ticks = ((usec / 10) * (get_tbclk() / 100000));
|
|
|
|
return ticks;
|
|
}
|
|
|
|
static inline unsigned long long tick_to_time(unsigned long long tick)
|
|
{
|
|
unsigned long freq;
|
|
|
|
asm volatile("mrc p15, 0, %0, c14, c0, 0" : "=r" (freq));
|
|
|
|
tick *= CONFIG_SYS_HZ;
|
|
do_div(tick, freq);
|
|
|
|
return tick;
|
|
}
|
|
|
|
static inline unsigned long long us_to_tick(unsigned long long usec)
|
|
{
|
|
unsigned long freq;
|
|
|
|
asm volatile("mrc p15, 0, %0, c14, c0, 0" : "=r" (freq));
|
|
|
|
usec = usec * freq + 999999;
|
|
do_div(usec, 1000000);
|
|
|
|
return usec;
|
|
}
|
|
|
|
int timer_init(void)
|
|
{
|
|
struct sctr_regs *sctr = (struct sctr_regs *)SCTR_BASE_ADDR;
|
|
unsigned long val, freq;
|
|
|
|
freq = CONFIG_SC_TIMER_CLK;
|
|
asm volatile("mcr p15, 0, %0, c14, c0, 0" : : "r" (freq));
|
|
|
|
writel(freq, &sctr->cntfid0);
|
|
|
|
/* Enable system counter */
|
|
val = readl(&sctr->cntcr);
|
|
val &= ~(SC_CNTCR_FREQ0 | SC_CNTCR_FREQ1);
|
|
val |= SC_CNTCR_FREQ0 | SC_CNTCR_ENABLE | SC_CNTCR_HDBG;
|
|
writel(val, &sctr->cntcr);
|
|
|
|
gd->arch.tbl = 0;
|
|
gd->arch.tbu = 0;
|
|
|
|
return 0;
|
|
}
|
|
|
|
unsigned long long get_ticks(void)
|
|
{
|
|
unsigned long long now;
|
|
|
|
asm volatile("mrrc p15, 0, %Q0, %R0, c14" : "=r" (now));
|
|
|
|
gd->arch.tbl = (unsigned long)(now & 0xffffffff);
|
|
gd->arch.tbu = (unsigned long)(now >> 32);
|
|
|
|
return now;
|
|
}
|
|
|
|
ulong get_timer_masked(void)
|
|
{
|
|
return tick_to_time(get_ticks());
|
|
}
|
|
|
|
ulong get_timer(ulong base)
|
|
{
|
|
return get_timer_masked() - base;
|
|
}
|
|
|
|
void __udelay(unsigned long usec)
|
|
{
|
|
unsigned long long tmp;
|
|
ulong tmo;
|
|
|
|
tmo = us_to_tick(usec);
|
|
tmp = get_ticks() + tmo; /* get current timestamp */
|
|
|
|
while (get_ticks() < tmp) /* loop till event */
|
|
/*NOP*/;
|
|
}
|
|
|
|
/*
|
|
* This function is derived from PowerPC code (timebase clock frequency).
|
|
* On ARM it returns the number of timer ticks per second.
|
|
*/
|
|
ulong get_tbclk(void)
|
|
{
|
|
unsigned long freq;
|
|
|
|
asm volatile("mrc p15, 0, %0, c14, c0, 0" : "=r" (freq));
|
|
|
|
return freq;
|
|
}
|