mirror of
https://github.com/brain-hackers/u-boot-brain
synced 2024-08-29 05:18:51 +09:00
![]() The Linux coding style guide (Documentation/process/coding-style.rst) clearly says: It's a **mistake** to use typedef for structures and pointers. Besides, using typedef for structures is annoying when you try to make headers self-contained. Let's say you have the following function declaration in a header: void foo(bd_t *bd); This is not self-contained since bd_t is not defined. To tell the compiler what 'bd_t' is, you need to include <asm/u-boot.h> #include <asm/u-boot.h> void foo(bd_t *bd); Then, the include direcective pulls in more bloat needlessly. If you use 'struct bd_info' instead, it is enough to put a forward declaration as follows: struct bd_info; void foo(struct bd_info *bd); Right, typedef'ing bd_t is a mistake. I used coccinelle to generate this commit. The semantic patch that makes this change is as follows: <smpl> @@ typedef bd_t; @@ -bd_t +struct bd_info </smpl> Signed-off-by: Masahiro Yamada <masahiroy@kernel.org> |
||
---|---|---|
.. | ||
tegra20 | ||
tegra30 | ||
tegra114 | ||
tegra124 | ||
tegra186 | ||
tegra210 | ||
ap.c | ||
arm64-mmu.c | ||
board2.c | ||
board.c | ||
cache.c | ||
cboot.c | ||
clock.c | ||
cmd_enterrcm.c | ||
cpu.c | ||
cpu.h | ||
dt-setup.c | ||
emc.c | ||
emc.h | ||
gpu.c | ||
ivc.c | ||
Kconfig | ||
Makefile | ||
pinmux-common.c | ||
pmc.c | ||
powergate.c | ||
psci.S | ||
spl.c | ||
sys_info.c | ||
xusb-padctl-common.c | ||
xusb-padctl-common.h | ||
xusb-padctl-dummy.c |