mirror of
https://github.com/brain-hackers/u-boot-brain
synced 2024-09-20 03:33:20 +09:00
35b65dd8ef
Historically, the reset_cpu() function had an `addr` parameter which was
meant to pass in an address of the reset vector location, where the CPU
should reset to. This feature is no longer used anywhere in U-Boot as
all reset_cpu() implementations now ignore the passed value. Generic
code has been added which always calls reset_cpu() with `0` which means
this feature can no longer be used easily anyway.
Over time, many implementations seem to have "misunderstood" the
existence of this parameter as a way to customize/parameterize the reset
(e.g. COLD vs WARM resets). As this is not properly supported, the
code will almost always not do what it is intended to (because all
call-sites just call reset_cpu() with 0).
To avoid confusion and to clean up the codebase from unused left-overs
of the past, remove the `addr` parameter entirely. Code which intends
to support different kinds of resets should be rewritten as a sysreset
driver instead.
This transformation was done with the following coccinelle patch:
@@
expression argvalue;
@@
- reset_cpu(argvalue)
+ reset_cpu()
@@
identifier argname;
type argtype;
@@
- reset_cpu(argtype argname)
+ reset_cpu(void)
{ ... }
Signed-off-by: Harald Seiler <hws@denx.de>
Reviewed-by: Simon Glass <sjg@chromium.org>
38 lines
945 B
C
38 lines
945 B
C
// SPDX-License-Identifier: GPL-2.0+
|
|
/*
|
|
* Cirrus Logic EP93xx CPU-specific support.
|
|
*
|
|
* Copyright (C) 2009 Matthias Kaehlcke <matthias@kaehlcke.net>
|
|
*
|
|
* Copyright (C) 2004, 2005
|
|
* Cory T. Tusar, Videon Central, Inc., <ctusar@videon-central.com>
|
|
*/
|
|
|
|
#include <common.h>
|
|
#include <cpu_func.h>
|
|
#include <asm/arch/ep93xx.h>
|
|
#include <asm/io.h>
|
|
|
|
/* We reset the CPU by generating a 1-->0 transition on DeviceCfg bit 31. */
|
|
extern void reset_cpu(void)
|
|
{
|
|
struct syscon_regs *syscon = (struct syscon_regs *)SYSCON_BASE;
|
|
uint32_t value;
|
|
|
|
/* Unlock DeviceCfg and set SWRST */
|
|
writel(0xAA, &syscon->sysswlock);
|
|
value = readl(&syscon->devicecfg);
|
|
value |= SYSCON_DEVICECFG_SWRST;
|
|
writel(value, &syscon->devicecfg);
|
|
|
|
/* Unlock DeviceCfg and clear SWRST */
|
|
writel(0xAA, &syscon->sysswlock);
|
|
value = readl(&syscon->devicecfg);
|
|
value &= ~SYSCON_DEVICECFG_SWRST;
|
|
writel(value, &syscon->devicecfg);
|
|
|
|
/* Dying... */
|
|
while (1)
|
|
; /* noop */
|
|
}
|