mirror of
https://github.com/brain-hackers/u-boot-brain
synced 2024-07-05 02:36:39 +09:00
b75d8dc564
The Linux coding style guide (Documentation/process/coding-style.rst) clearly says: It's a **mistake** to use typedef for structures and pointers. Besides, using typedef for structures is annoying when you try to make headers self-contained. Let's say you have the following function declaration in a header: void foo(bd_t *bd); This is not self-contained since bd_t is not defined. To tell the compiler what 'bd_t' is, you need to include <asm/u-boot.h> #include <asm/u-boot.h> void foo(bd_t *bd); Then, the include direcective pulls in more bloat needlessly. If you use 'struct bd_info' instead, it is enough to put a forward declaration as follows: struct bd_info; void foo(struct bd_info *bd); Right, typedef'ing bd_t is a mistake. I used coccinelle to generate this commit. The semantic patch that makes this change is as follows: <smpl> @@ typedef bd_t; @@ -bd_t +struct bd_info </smpl> Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
30 lines
704 B
C
30 lines
704 B
C
/* SPDX-License-Identifier: GPL-2.0+ */
|
|
/*
|
|
* bur_comon.h
|
|
*
|
|
* common board information header for B&R boards
|
|
*
|
|
* Copyright (C) 2013 Hannes Schmelzer <oe5hpm@oevsv.at>
|
|
* Bernecker & Rainer Industrieelektronik GmbH - http://www.br-automation.com
|
|
*/
|
|
|
|
#ifndef _BUR_COMMON_H_
|
|
#define _BUR_COMMON_H_
|
|
|
|
#if !CONFIG_IS_ENABLED(DM_VIDEO)
|
|
#include <../../../drivers/video/am335x-fb.h>
|
|
|
|
int load_lcdtiming(struct am335x_lcdpanel *panel);
|
|
#endif
|
|
|
|
void br_summaryscreen(void);
|
|
void pmicsetup(u32 mpupll, unsigned int bus);
|
|
void enable_uart0_pin_mux(void);
|
|
void enable_i2c_pin_mux(void);
|
|
void enable_board_pin_mux(void);
|
|
int board_eth_init(struct bd_info *bis);
|
|
|
|
int brdefaultip_setup(int bus, int chip);
|
|
|
|
#endif
|