mirror of
https://github.com/brain-hackers/u-boot-brain
synced 2024-08-21 01:18:52 +09:00
![]() v7_maint_dcache_all() does not work reliable when build with gcc6, see: https://bugzilla.redhat.com/show_bug.cgi?id=1318788 While debugging this I learned that v7_maint_dcache_all() is unreliable when build with gcc5 too when it is marked as noinline. This commit fixes the reliability issues by replacing the C-code with the ready to use asm implementation from the kernel. Given that this code when written as C-code clearly is quite fragile (also see the existing comments about the C-code being the way it is to get optimal assembly) and that we have a proven asm alternative, I believe that this is the best solution. Note that we actually already had a copy of the kernel's v7_flush_dcache_all() before this commit in arch/arm/mach-uniphier/arm32/lowlevel_init.S. This commit moves that code arch/arm/cpu/armv7/cache_v7_asm.S, renames it to __v7_flush_dcache_all(), and adds a v7_flush_dcache_all() wrapper which saves / restores the clobbered registers for use from C-code. Signed-off-by: Hans de Goede <hdegoede@redhat.com> Acked-by: Masahiro Yamada <yamada.masahiro@socionext.com> |
||
---|---|---|
.. | ||
arm32 | ||
bcu | ||
boot-mode | ||
clk | ||
debug-uart | ||
dram | ||
early-clk | ||
early-pinctrl | ||
init | ||
memconf | ||
pinctrl | ||
pll | ||
sbc | ||
board_common.c | ||
board_early_init_f.c | ||
board_early_init_r.c | ||
board_late_init.c | ||
boards.c | ||
cpu_info.c | ||
dram_init.c | ||
init.h | ||
Kconfig | ||
Makefile | ||
micro-support-card.c | ||
micro-support-card.h | ||
print_misc_info.c | ||
reset.c | ||
sc64-regs.h | ||
sc-regs.h | ||
sg-regs.h | ||
soc_info.c | ||
soc-info.h |