mirror of
https://github.com/brain-hackers/u-boot-brain
synced 2024-07-10 21:26:19 +09:00
935e09cdcb
Marek reports warnings in UniPhier pinctrl drivers when compiled by
GCC 6.x, like:
drivers/pinctrl/uniphier/pinctrl-uniphier-ld20.c:58:18: warning:
'usb3_muxvals' defined but not used [-Wunused-const-variable=]
static const int usb3_muxvals[] = {0, 0};
^~~~~~~~~~~~
My intention here is to compile minimum set of pin data for SPL to
save memory footprint, but GCC these days is clever enough to notice
unused data arrays.
We can fix it by sprinkling around __maybe_unused on those arrays,
but I did not do that because they are counterparts of the pinctrl
drivers in Linux. All the pin data were just copy-pasted from Linux
and are kept in sync for maintainability.
I chose a bit tricky way to fix the issue; calculate ARRAY_SIZE of
*_pins and *_muxvals and set their sum to an unused struct member.
This trick will satisfy GCC because the data arrays are used anyway,
but such data arrays will be dropped from the final binary because
the pointers to them are not used.
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Reported-by: Marek Vasut <marex@denx.de>
126 lines
3.3 KiB
C
126 lines
3.3 KiB
C
/*
|
|
* Copyright (C) 2015-2016 Socionext Inc.
|
|
* Author: Masahiro Yamada <yamada.masahiro@socionext.com>
|
|
*
|
|
* SPDX-License-Identifier: GPL-2.0+
|
|
*/
|
|
|
|
#ifndef __PINCTRL_UNIPHIER_H__
|
|
#define __PINCTRL_UNIPHIER_H__
|
|
|
|
#include <linux/bitops.h>
|
|
#include <linux/bug.h>
|
|
#include <linux/kernel.h>
|
|
#include <linux/types.h>
|
|
|
|
#define UNIPHIER_PIN_ATTR_PACKED(iectrl) (iectrl)
|
|
|
|
static inline unsigned int uniphier_pin_get_iectrl(unsigned long data)
|
|
{
|
|
return data;
|
|
}
|
|
|
|
/**
|
|
* struct uniphier_pinctrl_pin - pin data for UniPhier SoC
|
|
*
|
|
* @number: pin number
|
|
* @data: additional per-pin data
|
|
*/
|
|
struct uniphier_pinctrl_pin {
|
|
unsigned number;
|
|
unsigned long data;
|
|
};
|
|
|
|
/**
|
|
* struct uniphier_pinctrl_group - pin group data for UniPhier SoC
|
|
*
|
|
* @name: pin group name
|
|
* @pins: array of pins that belong to the group
|
|
* @num_pins: number of pins in the group
|
|
* @muxvals: array of values to be set to pinmux registers
|
|
*/
|
|
struct uniphier_pinctrl_group {
|
|
const char *name;
|
|
const unsigned *pins;
|
|
unsigned num_pins;
|
|
const int *muxvals;
|
|
};
|
|
|
|
/**
|
|
* struct uniphier_pinctrl_socdata - SoC data for UniPhier pin controller
|
|
*
|
|
* @pins: array of pin data
|
|
* @pins_count: number of pin data
|
|
* @groups: array of pin group data
|
|
* @groups_count: number of pin group data
|
|
* @functions: array of pinmux function names
|
|
* @functions_count: number of pinmux functions
|
|
* @mux_bits: bit width of each pinmux register
|
|
* @reg_stride: stride of pinmux register address
|
|
* @caps: SoC-specific capability flag
|
|
*/
|
|
struct uniphier_pinctrl_socdata {
|
|
const struct uniphier_pinctrl_pin *pins;
|
|
int pins_count;
|
|
const struct uniphier_pinctrl_group *groups;
|
|
int groups_count;
|
|
const char * const *functions;
|
|
int functions_count;
|
|
unsigned caps;
|
|
#define UNIPHIER_PINCTRL_CAPS_PERPIN_IECTRL BIT(2)
|
|
#define UNIPHIER_PINCTRL_CAPS_DBGMUX_SEPARATE BIT(1)
|
|
#define UNIPHIER_PINCTRL_CAPS_MUX_4BIT BIT(0)
|
|
};
|
|
|
|
#define UNIPHIER_PINCTRL_PIN(a, b) \
|
|
{ \
|
|
.number = a, \
|
|
.data = UNIPHIER_PIN_ATTR_PACKED(b), \
|
|
}
|
|
|
|
#define __UNIPHIER_PINCTRL_GROUP(grp) \
|
|
{ \
|
|
.name = #grp, \
|
|
.pins = grp##_pins, \
|
|
.num_pins = ARRAY_SIZE(grp##_pins), \
|
|
.muxvals = grp##_muxvals + \
|
|
BUILD_BUG_ON_ZERO(ARRAY_SIZE(grp##_pins) != \
|
|
ARRAY_SIZE(grp##_muxvals)), \
|
|
}
|
|
|
|
#define __UNIPHIER_PINMUX_FUNCTION(func) #func
|
|
|
|
#ifdef CONFIG_SPL_BUILD
|
|
/*
|
|
* a tricky way to drop unneeded *_pins and *_muxvals arrays from SPL,
|
|
* suppressing "defined but not used" warnings.
|
|
*/
|
|
#define UNIPHIER_PINCTRL_GROUP(grp) \
|
|
{ .num_pins = ARRAY_SIZE(grp##_pins) + ARRAY_SIZE(grp##_muxvals) }
|
|
#define UNIPHIER_PINMUX_FUNCTION(func) NULL
|
|
#else
|
|
#define UNIPHIER_PINCTRL_GROUP(grp) __UNIPHIER_PINCTRL_GROUP(grp)
|
|
#define UNIPHIER_PINMUX_FUNCTION(func) __UNIPHIER_PINMUX_FUNCTION(func)
|
|
#endif
|
|
|
|
#define UNIPHIER_PINCTRL_GROUP_SPL(grp) __UNIPHIER_PINCTRL_GROUP(grp)
|
|
#define UNIPHIER_PINMUX_FUNCTION_SPL(func) __UNIPHIER_PINMUX_FUNCTION(func)
|
|
|
|
/**
|
|
* struct uniphier_pinctrl_priv - private data for UniPhier pinctrl driver
|
|
*
|
|
* @base: base address of the pinctrl device
|
|
* @socdata: SoC specific data
|
|
*/
|
|
struct uniphier_pinctrl_priv {
|
|
void __iomem *base;
|
|
struct uniphier_pinctrl_socdata *socdata;
|
|
};
|
|
|
|
extern const struct pinctrl_ops uniphier_pinctrl_ops;
|
|
|
|
int uniphier_pinctrl_probe(struct udevice *dev,
|
|
struct uniphier_pinctrl_socdata *socdata);
|
|
|
|
#endif /* __PINCTRL_UNIPHIER_H__ */
|