mirror of
https://github.com/brain-hackers/u-boot-brain
synced 2024-08-29 05:18:51 +09:00
![Simon Glass](/assets/img/avatar_default.png)
This feature was dropped from U-Boot some time ago:
f12f96cfaf
(sf: Drop spl_flash_get_sw_write_prot")
However, we do need a way to see if a flash device is write-protected,
since if it is, it may not be possible to write to do (i.e. failing to
write is expected).
I am not sure of the correct layer to implement this, so this patch is a
stab at it. If spi-flash makes sense then I will add to the 'sf' also.
Re the points mentioned in the removal commit:
1) This kind of requirement can be achieved using existing
flash operations and flash locking API calls instead of
making a separate flash API.
Which uclass is this?
2) Technically there is no real hardware user for this API to
use in the source tree.
I do want coral (at least) to support this.
3) Having a flash operations API for simple register read bits
also make difficult to extend the flash operations.
This new patch only mentions write-protect being on or off, rather than
the actual mechanism.
4) Instead of touching generic code, it is possible to have
this functionality inside spinor operations in the form of
flash hooks or fixups for associated flash chips.
That sounds to me like what drivers are for. But we still need some sort
of API for it to be accessible.
Signed-off-by: Simon Glass <sjg@chromium.org>
110 lines
2.4 KiB
C
110 lines
2.4 KiB
C
// SPDX-License-Identifier: GPL-2.0+
|
|
/*
|
|
* Copyright (c) 2014 Google, Inc
|
|
*/
|
|
|
|
#include <common.h>
|
|
#include <dm.h>
|
|
#include <log.h>
|
|
#include <malloc.h>
|
|
#include <spi.h>
|
|
#include <spi_flash.h>
|
|
#include <asm/global_data.h>
|
|
#include <dm/device-internal.h>
|
|
#include "sf_internal.h"
|
|
|
|
DECLARE_GLOBAL_DATA_PTR;
|
|
|
|
int spi_flash_read_dm(struct udevice *dev, u32 offset, size_t len, void *buf)
|
|
{
|
|
return log_ret(sf_get_ops(dev)->read(dev, offset, len, buf));
|
|
}
|
|
|
|
int spi_flash_write_dm(struct udevice *dev, u32 offset, size_t len,
|
|
const void *buf)
|
|
{
|
|
return log_ret(sf_get_ops(dev)->write(dev, offset, len, buf));
|
|
}
|
|
|
|
int spi_flash_erase_dm(struct udevice *dev, u32 offset, size_t len)
|
|
{
|
|
return log_ret(sf_get_ops(dev)->erase(dev, offset, len));
|
|
}
|
|
|
|
int spl_flash_get_sw_write_prot(struct udevice *dev)
|
|
{
|
|
struct dm_spi_flash_ops *ops = sf_get_ops(dev);
|
|
|
|
if (!ops->get_sw_write_prot)
|
|
return -ENOSYS;
|
|
return log_ret(ops->get_sw_write_prot(dev));
|
|
}
|
|
|
|
/*
|
|
* TODO(sjg@chromium.org): This is an old-style function. We should remove
|
|
* it when all SPI flash drivers use dm
|
|
*/
|
|
struct spi_flash *spi_flash_probe(unsigned int bus, unsigned int cs,
|
|
unsigned int max_hz, unsigned int spi_mode)
|
|
{
|
|
struct udevice *dev;
|
|
|
|
if (spi_flash_probe_bus_cs(bus, cs, max_hz, spi_mode, &dev))
|
|
return NULL;
|
|
|
|
return dev_get_uclass_priv(dev);
|
|
}
|
|
|
|
int spi_flash_probe_bus_cs(unsigned int busnum, unsigned int cs,
|
|
unsigned int max_hz, unsigned int spi_mode,
|
|
struct udevice **devp)
|
|
{
|
|
struct spi_slave *slave;
|
|
struct udevice *bus;
|
|
char *str;
|
|
int ret;
|
|
|
|
#if defined(CONFIG_SPL_BUILD) && CONFIG_IS_ENABLED(USE_TINY_PRINTF)
|
|
str = "spi_flash";
|
|
#else
|
|
char name[30];
|
|
|
|
snprintf(name, sizeof(name), "spi_flash@%d:%d", busnum, cs);
|
|
str = strdup(name);
|
|
#endif
|
|
ret = spi_get_bus_and_cs(busnum, cs, max_hz, spi_mode,
|
|
"jedec_spi_nor", str, &bus, &slave);
|
|
if (ret)
|
|
return ret;
|
|
|
|
*devp = slave->dev;
|
|
return 0;
|
|
}
|
|
|
|
static int spi_flash_post_bind(struct udevice *dev)
|
|
{
|
|
#if defined(CONFIG_NEEDS_MANUAL_RELOC)
|
|
struct dm_spi_flash_ops *ops = sf_get_ops(dev);
|
|
static int reloc_done;
|
|
|
|
if (!reloc_done) {
|
|
if (ops->read)
|
|
ops->read += gd->reloc_off;
|
|
if (ops->write)
|
|
ops->write += gd->reloc_off;
|
|
if (ops->erase)
|
|
ops->erase += gd->reloc_off;
|
|
|
|
reloc_done++;
|
|
}
|
|
#endif
|
|
return 0;
|
|
}
|
|
|
|
UCLASS_DRIVER(spi_flash) = {
|
|
.id = UCLASS_SPI_FLASH,
|
|
.name = "spi_flash",
|
|
.post_bind = spi_flash_post_bind,
|
|
.per_device_auto = sizeof(struct spi_nor),
|
|
};
|