mirror of
https://github.com/brain-hackers/u-boot-brain
synced 2024-08-29 05:18:51 +09:00
![Simon Glass](/assets/img/avatar_default.png)
The uclass pre-probe functions may end up calling back into the device in some circumstances. This can fail if recursion takes place. Adjust the ordering so that we mark the device as active early, then retract this later if needed. Signed-off-by: Simon Glass <sjg@chromium.org> Reviewed-by: Marek Vasut <marex@denx.de>
119 lines
2.4 KiB
C
119 lines
2.4 KiB
C
/*
|
|
* Copyright (c) 2013 Google, Inc
|
|
*
|
|
* (C) Copyright 2012
|
|
* Pavel Herrmann <morpheus.ibis@gmail.com>
|
|
*
|
|
* SPDX-License-Identifier: GPL-2.0+
|
|
*/
|
|
|
|
#include <common.h>
|
|
#include <malloc.h>
|
|
#include <dm.h>
|
|
#include <errno.h>
|
|
#include <dm/test.h>
|
|
#include <dm/ut.h>
|
|
#include <asm/io.h>
|
|
#include <linux/list.h>
|
|
|
|
static struct dm_test_state *dms = &global_test_state;
|
|
|
|
int test_ping(struct udevice *dev, int pingval, int *pingret)
|
|
{
|
|
const struct test_ops *ops = device_get_ops(dev);
|
|
|
|
if (!ops->ping)
|
|
return -ENOSYS;
|
|
|
|
return ops->ping(dev, pingval, pingret);
|
|
}
|
|
|
|
static int test_post_bind(struct udevice *dev)
|
|
{
|
|
dm_testdrv_op_count[DM_TEST_OP_POST_BIND]++;
|
|
ut_assert(!device_active(dev));
|
|
|
|
return 0;
|
|
}
|
|
|
|
static int test_pre_unbind(struct udevice *dev)
|
|
{
|
|
dm_testdrv_op_count[DM_TEST_OP_PRE_UNBIND]++;
|
|
|
|
return 0;
|
|
}
|
|
|
|
static int test_pre_probe(struct udevice *dev)
|
|
{
|
|
struct dm_test_uclass_perdev_priv *priv = dev_get_uclass_priv(dev);
|
|
|
|
dm_testdrv_op_count[DM_TEST_OP_PRE_PROBE]++;
|
|
ut_assert(priv);
|
|
ut_assert(device_active(dev));
|
|
|
|
return 0;
|
|
}
|
|
|
|
static int test_post_probe(struct udevice *dev)
|
|
{
|
|
struct udevice *prev = list_entry(dev->uclass_node.prev,
|
|
struct udevice, uclass_node);
|
|
|
|
struct dm_test_uclass_perdev_priv *priv = dev_get_uclass_priv(dev);
|
|
struct uclass *uc = dev->uclass;
|
|
|
|
dm_testdrv_op_count[DM_TEST_OP_POST_PROBE]++;
|
|
ut_assert(priv);
|
|
ut_assert(device_active(dev));
|
|
priv->base_add = 0;
|
|
if (dms->skip_post_probe)
|
|
return 0;
|
|
if (&prev->uclass_node != &uc->dev_head) {
|
|
struct dm_test_uclass_perdev_priv *prev_uc_priv
|
|
= dev_get_uclass_priv(prev);
|
|
struct dm_test_pdata *pdata = prev->platdata;
|
|
|
|
ut_assert(pdata);
|
|
ut_assert(prev_uc_priv);
|
|
priv->base_add = prev_uc_priv->base_add + pdata->ping_add;
|
|
}
|
|
|
|
return 0;
|
|
}
|
|
|
|
static int test_pre_remove(struct udevice *dev)
|
|
{
|
|
dm_testdrv_op_count[DM_TEST_OP_PRE_REMOVE]++;
|
|
|
|
return 0;
|
|
}
|
|
|
|
static int test_init(struct uclass *uc)
|
|
{
|
|
dm_testdrv_op_count[DM_TEST_OP_INIT]++;
|
|
ut_assert(uc->priv);
|
|
|
|
return 0;
|
|
}
|
|
|
|
static int test_destroy(struct uclass *uc)
|
|
{
|
|
dm_testdrv_op_count[DM_TEST_OP_DESTROY]++;
|
|
|
|
return 0;
|
|
}
|
|
|
|
UCLASS_DRIVER(test) = {
|
|
.name = "test",
|
|
.id = UCLASS_TEST,
|
|
.post_bind = test_post_bind,
|
|
.pre_unbind = test_pre_unbind,
|
|
.pre_probe = test_pre_probe,
|
|
.post_probe = test_post_probe,
|
|
.pre_remove = test_pre_remove,
|
|
.init = test_init,
|
|
.destroy = test_destroy,
|
|
.priv_auto_alloc_size = sizeof(struct dm_test_uclass_priv),
|
|
.per_device_auto_alloc_size = sizeof(struct dm_test_uclass_perdev_priv),
|
|
};
|