mirror of
https://github.com/brain-hackers/u-boot-brain
synced 2024-07-27 05:13:44 +09:00
b75d8dc564
The Linux coding style guide (Documentation/process/coding-style.rst) clearly says: It's a **mistake** to use typedef for structures and pointers. Besides, using typedef for structures is annoying when you try to make headers self-contained. Let's say you have the following function declaration in a header: void foo(bd_t *bd); This is not self-contained since bd_t is not defined. To tell the compiler what 'bd_t' is, you need to include <asm/u-boot.h> #include <asm/u-boot.h> void foo(bd_t *bd); Then, the include direcective pulls in more bloat needlessly. If you use 'struct bd_info' instead, it is enough to put a forward declaration as follows: struct bd_info; void foo(struct bd_info *bd); Right, typedef'ing bd_t is a mistake. I used coccinelle to generate this commit. The semantic patch that makes this change is as follows: <smpl> @@ typedef bd_t; @@ -bd_t +struct bd_info </smpl> Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
72 lines
1.7 KiB
C
72 lines
1.7 KiB
C
// SPDX-License-Identifier: GPL-2.0+
|
|
/*
|
|
* (C) Copyright 2013 Keymile AG
|
|
* Valentin Longchamp <valentin.longchamp@keymile.com>
|
|
*/
|
|
|
|
#include <common.h>
|
|
#include <net.h>
|
|
#include <netdev.h>
|
|
#include <fm_eth.h>
|
|
#include <fsl_mdio.h>
|
|
#include <phy.h>
|
|
|
|
int board_eth_init(struct bd_info *bis)
|
|
{
|
|
int ret = 0;
|
|
#ifdef CONFIG_FMAN_ENET
|
|
struct fsl_pq_mdio_info dtsec_mdio_info;
|
|
|
|
printf("Initializing Fman\n");
|
|
|
|
dtsec_mdio_info.regs =
|
|
(struct tsec_mii_mng *)CONFIG_SYS_FM1_DTSEC1_MDIO_ADDR;
|
|
dtsec_mdio_info.name = DEFAULT_FM_MDIO_NAME;
|
|
|
|
/* Register the real 1G MDIO bus */
|
|
fsl_pq_mdio_init(bis, &dtsec_mdio_info);
|
|
|
|
/* DTESC1/2 don't have a PHY, they are temporarily disabled
|
|
* so that u-boot doesn't try to unsuccessfuly enable them */
|
|
fm_disable_port(FM1_DTSEC1);
|
|
fm_disable_port(FM1_DTSEC2);
|
|
|
|
/*
|
|
* Program RGMII DTSEC5 (FM1 MAC5) on the EC2 physical itf
|
|
* This is the debug interface, the only one used in u-boot
|
|
*/
|
|
fm_info_set_phy_address(FM1_DTSEC5, CONFIG_SYS_FM1_DTSEC5_PHY_ADDR);
|
|
fm_info_set_mdio(FM1_DTSEC5,
|
|
miiphy_get_dev_by_name(DEFAULT_FM_MDIO_NAME));
|
|
|
|
ret = cpu_eth_init(bis);
|
|
|
|
/* reenable DTSEC1/2 for later (kernel) */
|
|
fm_enable_port(FM1_DTSEC1);
|
|
fm_enable_port(FM1_DTSEC2);
|
|
#endif
|
|
|
|
return ret;
|
|
}
|
|
|
|
#if defined(CONFIG_PHYLIB) && defined(CONFIG_PHY_MARVELL)
|
|
|
|
#define mv88E1118_PAGE_REG 22
|
|
|
|
int board_phy_config(struct phy_device *phydev)
|
|
{
|
|
if (phydev->addr == CONFIG_SYS_FM1_DTSEC5_PHY_ADDR) {
|
|
/* driver config is good */
|
|
if (phydev->drv->config)
|
|
phydev->drv->config(phydev);
|
|
|
|
/* but we still need to fix the LEDs */
|
|
phy_write(phydev, MDIO_DEVAD_NONE, mv88E1118_PAGE_REG, 0x0003);
|
|
phy_write(phydev, MDIO_DEVAD_NONE, 0x10, 0x0840);
|
|
phy_write(phydev, MDIO_DEVAD_NONE, mv88E1118_PAGE_REG, 0x0000);
|
|
}
|
|
|
|
return 0;
|
|
}
|
|
#endif
|