mirror of
https://github.com/brain-hackers/u-boot-brain
synced 2024-06-09 23:36:03 +09:00
b75d8dc564
The Linux coding style guide (Documentation/process/coding-style.rst) clearly says: It's a **mistake** to use typedef for structures and pointers. Besides, using typedef for structures is annoying when you try to make headers self-contained. Let's say you have the following function declaration in a header: void foo(bd_t *bd); This is not self-contained since bd_t is not defined. To tell the compiler what 'bd_t' is, you need to include <asm/u-boot.h> #include <asm/u-boot.h> void foo(bd_t *bd); Then, the include direcective pulls in more bloat needlessly. If you use 'struct bd_info' instead, it is enough to put a forward declaration as follows: struct bd_info; void foo(struct bd_info *bd); Right, typedef'ing bd_t is a mistake. I used coccinelle to generate this commit. The semantic patch that makes this change is as follows: <smpl> @@ typedef bd_t; @@ -bd_t +struct bd_info </smpl> Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
27 lines
577 B
C
27 lines
577 B
C
// SPDX-License-Identifier: GPL-2.0
|
|
/*
|
|
* Copyright (C) 2016 Imagination Technologies
|
|
*/
|
|
|
|
#include <common.h>
|
|
#include <fdt_support.h>
|
|
|
|
int ft_board_setup(void *blob, struct bd_info *bd)
|
|
{
|
|
DECLARE_GLOBAL_DATA_PTR;
|
|
u64 mem_start[2], mem_size[2];
|
|
int mem_regions;
|
|
|
|
mem_start[0] = 0;
|
|
mem_size[0] = min_t(u64, 256llu << 20, gd->ram_size);
|
|
mem_regions = 1;
|
|
|
|
if (gd->ram_size > mem_size[0]) {
|
|
mem_start[1] = 0x80000000 + mem_size[0];
|
|
mem_size[1] = gd->ram_size - mem_size[0];
|
|
mem_regions++;
|
|
}
|
|
|
|
return fdt_fixup_memory_banks(blob, mem_start, mem_size, mem_regions);
|
|
}
|