mirror of
https://github.com/brain-hackers/u-boot-brain
synced 2024-06-09 23:36:03 +09:00
b75d8dc564
The Linux coding style guide (Documentation/process/coding-style.rst) clearly says: It's a **mistake** to use typedef for structures and pointers. Besides, using typedef for structures is annoying when you try to make headers self-contained. Let's say you have the following function declaration in a header: void foo(bd_t *bd); This is not self-contained since bd_t is not defined. To tell the compiler what 'bd_t' is, you need to include <asm/u-boot.h> #include <asm/u-boot.h> void foo(bd_t *bd); Then, the include direcective pulls in more bloat needlessly. If you use 'struct bd_info' instead, it is enough to put a forward declaration as follows: struct bd_info; void foo(struct bd_info *bd); Right, typedef'ing bd_t is a mistake. I used coccinelle to generate this commit. The semantic patch that makes this change is as follows: <smpl> @@ typedef bd_t; @@ -bd_t +struct bd_info </smpl> Signed-off-by: Masahiro Yamada <masahiroy@kernel.org> |
||
|---|---|---|
| .. | ||
| corenet_ds.c | ||
| corenet_ds.h | ||
| ddr.c | ||
| eth_hydra.c | ||
| eth_p4080.c | ||
| eth_superhydra.c | ||
| Kconfig | ||
| MAINTAINERS | ||
| Makefile | ||
| p3041ds_ddr.c | ||
| p4080ds_ddr.c | ||
| p5020ds_ddr.c | ||
| p5040ds_ddr.c | ||
| pbi.cfg | ||
| rcw_p2041rdb.cfg | ||
| rcw_p3041ds.cfg | ||
| rcw_p4080ds.cfg | ||
| rcw_p5020ds.cfg | ||
| rcw_p5040ds.cfg | ||