mirror of
https://github.com/brain-hackers/u-boot-brain
synced 2024-08-30 22:08:52 +09:00
![Masahiro Yamada](/assets/img/avatar_default.png)
The Linux coding style guide (Documentation/process/coding-style.rst) clearly says: It's a **mistake** to use typedef for structures and pointers. Besides, using typedef for structures is annoying when you try to make headers self-contained. Let's say you have the following function declaration in a header: void foo(bd_t *bd); This is not self-contained since bd_t is not defined. To tell the compiler what 'bd_t' is, you need to include <asm/u-boot.h> #include <asm/u-boot.h> void foo(bd_t *bd); Then, the include direcective pulls in more bloat needlessly. If you use 'struct bd_info' instead, it is enough to put a forward declaration as follows: struct bd_info; void foo(struct bd_info *bd); Right, typedef'ing bd_t is a mistake. I used coccinelle to generate this commit. The semantic patch that makes this change is as follows: <smpl> @@ typedef bd_t; @@ -bd_t +struct bd_info </smpl> Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
65 lines
2.0 KiB
C
65 lines
2.0 KiB
C
/* SPDX-License-Identifier: GPL-2.0+ */
|
|
/*
|
|
* Copyright 2009-2012, 2013 Freescale Semiconductor, Inc.
|
|
* Jun-jie Zhang <b18070@freescale.com>
|
|
* Mingkai Hu <Mingkai.hu@freescale.com>
|
|
*/
|
|
|
|
#ifndef __FSL_PHY_H__
|
|
#define __FSL_PHY_H__
|
|
|
|
#include <net.h>
|
|
#include <miiphy.h>
|
|
|
|
struct tsec_mii_mng {
|
|
u32 miimcfg; /* MII management configuration reg */
|
|
u32 miimcom; /* MII management command reg */
|
|
u32 miimadd; /* MII management address reg */
|
|
u32 miimcon; /* MII management control reg */
|
|
u32 miimstat; /* MII management status reg */
|
|
u32 miimind; /* MII management indication reg */
|
|
u32 ifstat; /* Interface Status Register */
|
|
};
|
|
|
|
int fdt_fixup_phy_connection(void *blob, int offset, phy_interface_t phyc);
|
|
|
|
/* PHY register offsets */
|
|
#define PHY_EXT_PAGE_ACCESS 0x1f
|
|
|
|
/* MII Management Configuration Register */
|
|
#define MIIMCFG_RESET_MGMT 0x80000000
|
|
#define MIIMCFG_MGMT_CLOCK_SELECT 0x00000007
|
|
#define MIIMCFG_INIT_VALUE 0x00000003
|
|
|
|
/* MII Management Command Register */
|
|
#define MIIMCOM_READ_CYCLE 0x00000001
|
|
#define MIIMCOM_SCAN_CYCLE 0x00000002
|
|
|
|
/* MII Management Address Register */
|
|
#define MIIMADD_PHY_ADDR_SHIFT 8
|
|
|
|
/* MII Management Indicator Register */
|
|
#define MIIMIND_BUSY 0x00000001
|
|
#define MIIMIND_NOTVALID 0x00000004
|
|
|
|
void tsec_local_mdio_write(struct tsec_mii_mng __iomem *phyregs, int port_addr,
|
|
int dev_addr, int reg, int value);
|
|
int tsec_local_mdio_read(struct tsec_mii_mng __iomem *phyregs, int port_addr,
|
|
int dev_addr, int regnum);
|
|
int tsec_phy_read(struct mii_dev *bus, int addr, int dev_addr, int regnum);
|
|
int tsec_phy_write(struct mii_dev *bus, int addr, int dev_addr, int regnum,
|
|
u16 value);
|
|
int memac_mdio_write(struct mii_dev *bus, int port_addr, int dev_addr,
|
|
int regnum, u16 value);
|
|
int memac_mdio_read(struct mii_dev *bus, int port_addr, int dev_addr,
|
|
int regnum);
|
|
int memac_mdio_reset(struct mii_dev *bus);
|
|
|
|
struct fsl_pq_mdio_info {
|
|
struct tsec_mii_mng __iomem *regs;
|
|
char *name;
|
|
};
|
|
int fsl_pq_mdio_init(struct bd_info *bis, struct fsl_pq_mdio_info *info);
|
|
|
|
#endif /* __FSL_PHY_H__ */
|