mirror of
https://github.com/brain-hackers/u-boot-brain
synced 2024-06-09 23:36:03 +09:00
89a5317ae2
Fix test_mmc_dev(), test_mmc_rescan(), test_mmc_info() not to use the same configuration data that test_mmc_rd() does. Doing so causes the following issues: * The new code uncondtionally expects certain keys to exist in the configuration data. These keys do not exist in existing configuration data since they were not previously required, and there was no notification re: a requirement to add these new keys. This causes test failures due to thrown exceptions when accessing the non-existent keys. * The new tests logically operate on different objects. test_mmc_rd() operates on ranges of sectors on an MMC device (which may be the entire set of sectors of a device, or a part of a device), whereas all the new tests operate solely on entire devices. These are separate things, and it's entirely likely that the user will wish to runs the two types of tests on different sets of data; see the example configuration data that this commit adds. Ideally, the new tests would have been added to a separate Python file, since they aren' closely related to the existing tests. FIXME: Marek, can you please replace the "???" in this patch with some reasonable looking data? Thanks. Cc: Marek Vasut <marek.vasut@gmail.com> Fixes:4ffec8cdf5("test/py: mmc: Add 'mmc info' test") Fixes:ce4b2cafa7("test/py: mmc: Add 'mmc rescan' test") Fixes:86dfd152c9("test/py: mmc: Add 'mmc dev' test") Signed-off-by: Stephen Warren <swarren@nvidia.com>
287 lines
8.3 KiB
Python
287 lines
8.3 KiB
Python
# SPDX-License-Identifier: GPL-2.0
|
|
# Copyright (c) 2018, NVIDIA CORPORATION. All rights reserved.
|
|
|
|
# Test U-Boot's "mmc read" command. The test reads data from the eMMC or SD
|
|
# card, and validates the no errors occurred, and that the expected data was
|
|
# read if the test configuration contains a CRC of the expected data.
|
|
|
|
import pytest
|
|
import time
|
|
import u_boot_utils
|
|
|
|
"""
|
|
This test relies on boardenv_* to containing configuration values to define
|
|
which MMC devices should be tested. For example:
|
|
|
|
# Configuration data for test_mmc_dev, test_mmc_rescan, test_mmc_info; defines
|
|
# whole MMC devices that mmc dev/rescan/info commands may operate upon.
|
|
env__mmc_dev_configs = (
|
|
{
|
|
'fixture_id': 'emmc-boot0',
|
|
'is_emmc': True,
|
|
'devid': 0,
|
|
'partid': 1,
|
|
'info_device': ???,
|
|
'info_speed': ???,
|
|
'info_mode': ???,
|
|
'info_buswidth': ???.
|
|
},
|
|
{
|
|
'fixture_id': 'emmc-boot1',
|
|
'is_emmc': True,
|
|
'devid': 0,
|
|
'partid': 2,
|
|
'info_device': ???,
|
|
'info_speed': ???,
|
|
'info_mode': ???,
|
|
'info_buswidth': ???.
|
|
},
|
|
{
|
|
'fixture_id': 'emmc-data',
|
|
'is_emmc': True,
|
|
'devid': 0,
|
|
'partid': 0,
|
|
'info_device': ???,
|
|
'info_speed': ???,
|
|
'info_mode': ???,
|
|
'info_buswidth': ???.
|
|
},
|
|
{
|
|
'fixture_id': 'sd',
|
|
'is_emmc': False,
|
|
'devid': 1,
|
|
'partid': None,
|
|
'info_device': ???,
|
|
'info_speed': ???,
|
|
'info_mode': ???,
|
|
'info_buswidth': ???.
|
|
},
|
|
}
|
|
|
|
# Configuration data for test_mmc_rd; defines regions of the MMC (entire
|
|
# devices, or ranges of sectors) which can be read:
|
|
env__mmc_rd_configs = (
|
|
{
|
|
'fixture_id': 'emmc-boot0',
|
|
'is_emmc': True,
|
|
'devid': 0,
|
|
'partid': 1,
|
|
'sector': 0x10,
|
|
'count': 1,
|
|
},
|
|
{
|
|
'fixture_id': 'emmc-boot1',
|
|
'is_emmc': True,
|
|
'devid': 0,
|
|
'partid': 2,
|
|
'sector': 0x10,
|
|
'count': 1,
|
|
},
|
|
{
|
|
'fixture_id': 'emmc-data',
|
|
'is_emmc': True,
|
|
'devid': 0,
|
|
'partid': 0,
|
|
'sector': 0x10,
|
|
'count': 0x1000,
|
|
},
|
|
{
|
|
'fixture_id': 'sd-mbr',
|
|
'is_emmc': False,
|
|
'devid': 1,
|
|
'partid': None,
|
|
'sector': 0,
|
|
'count': 1,
|
|
'crc32': '8f6ecf0d',
|
|
},
|
|
{
|
|
'fixture_id': 'sd-large',
|
|
'is_emmc': False,
|
|
'devid': 1,
|
|
'partid': None,
|
|
'sector': 0x10,
|
|
'count': 0x1000,
|
|
},
|
|
)
|
|
"""
|
|
|
|
def mmc_dev(u_boot_console, is_emmc, devid, partid):
|
|
"""Run the "mmc dev" command.
|
|
|
|
Args:
|
|
u_boot_console: A U-Boot console connection.
|
|
is_emmc: Whether the device is eMMC
|
|
devid: Device ID
|
|
partid: Partition ID
|
|
|
|
Returns:
|
|
Nothing.
|
|
"""
|
|
|
|
# Select MMC device
|
|
cmd = 'mmc dev %d' % devid
|
|
if is_emmc:
|
|
cmd += ' %d' % partid
|
|
response = u_boot_console.run_command(cmd)
|
|
assert 'no card present' not in response
|
|
if is_emmc:
|
|
partid_response = '(part %d)' % partid
|
|
else:
|
|
partid_response = ''
|
|
good_response = 'mmc%d%s is current device' % (devid, partid_response)
|
|
assert good_response in response
|
|
|
|
@pytest.mark.buildconfigspec('cmd_mmc')
|
|
def test_mmc_dev(u_boot_console, env__mmc_dev_config):
|
|
"""Test the "mmc dev" command.
|
|
|
|
Args:
|
|
u_boot_console: A U-Boot console connection.
|
|
env__mmc_dev_config: The single MMC configuration on which
|
|
to run the test. See the file-level comment above for details
|
|
of the format.
|
|
|
|
Returns:
|
|
Nothing.
|
|
"""
|
|
|
|
is_emmc = env__mmc_dev_config['is_emmc']
|
|
devid = env__mmc_dev_config['devid']
|
|
partid = env__mmc_dev_config.get('partid', 0)
|
|
|
|
# Select MMC device
|
|
mmc_dev(u_boot_console, is_emmc, devid, partid)
|
|
|
|
@pytest.mark.buildconfigspec('cmd_mmc')
|
|
def test_mmc_rescan(u_boot_console, env__mmc_dev_config):
|
|
"""Test the "mmc rescan" command.
|
|
|
|
Args:
|
|
u_boot_console: A U-Boot console connection.
|
|
env__mmc_dev_config: The single MMC configuration on which
|
|
to run the test. See the file-level comment above for details
|
|
of the format.
|
|
|
|
Returns:
|
|
Nothing.
|
|
"""
|
|
|
|
is_emmc = env__mmc_dev_config['is_emmc']
|
|
devid = env__mmc_dev_config['devid']
|
|
partid = env__mmc_dev_config.get('partid', 0)
|
|
|
|
# Select MMC device
|
|
mmc_dev(u_boot_console, is_emmc, devid, partid)
|
|
|
|
# Rescan MMC device
|
|
cmd = 'mmc rescan'
|
|
response = u_boot_console.run_command(cmd)
|
|
assert 'no card present' not in response
|
|
|
|
@pytest.mark.buildconfigspec('cmd_mmc')
|
|
def test_mmc_info(u_boot_console, env__mmc_dev_config):
|
|
"""Test the "mmc info" command.
|
|
|
|
Args:
|
|
u_boot_console: A U-Boot console connection.
|
|
env__mmc_dev_config: The single MMC configuration on which
|
|
to run the test. See the file-level comment above for details
|
|
of the format.
|
|
|
|
Returns:
|
|
Nothing.
|
|
"""
|
|
|
|
is_emmc = env__mmc_dev_config['is_emmc']
|
|
devid = env__mmc_dev_config['devid']
|
|
partid = env__mmc_dev_config.get('partid', 0)
|
|
info_device = env__mmc_dev_config['info_device']
|
|
info_speed = env__mmc_dev_config['info_speed']
|
|
info_mode = env__mmc_dev_config['info_mode']
|
|
info_buswidth = env__mmc_dev_config['info_buswidth']
|
|
|
|
# Select MMC device
|
|
mmc_dev(u_boot_console, is_emmc, devid, partid)
|
|
|
|
# Read MMC device information
|
|
cmd = 'mmc info'
|
|
response = u_boot_console.run_command(cmd)
|
|
good_response = "Device: %s" % info_device
|
|
assert good_response in response
|
|
good_response = "Bus Speed: %s" % info_speed
|
|
assert good_response in response
|
|
good_response = "Mode : %s" % info_mode
|
|
assert good_response in response
|
|
good_response = "Bus Width: %s" % info_buswidth
|
|
assert good_response in response
|
|
|
|
@pytest.mark.buildconfigspec('cmd_mmc')
|
|
def test_mmc_rd(u_boot_console, env__mmc_rd_config):
|
|
"""Test the "mmc read" command.
|
|
|
|
Args:
|
|
u_boot_console: A U-Boot console connection.
|
|
env__mmc_rd_config: The single MMC configuration on which
|
|
to run the test. See the file-level comment above for details
|
|
of the format.
|
|
|
|
Returns:
|
|
Nothing.
|
|
"""
|
|
|
|
is_emmc = env__mmc_rd_config['is_emmc']
|
|
devid = env__mmc_rd_config['devid']
|
|
partid = env__mmc_rd_config.get('partid', 0)
|
|
sector = env__mmc_rd_config.get('sector', 0)
|
|
count_sectors = env__mmc_rd_config.get('count', 1)
|
|
expected_crc32 = env__mmc_rd_config.get('crc32', None)
|
|
read_duration_max = env__mmc_rd_config.get('read_duration_max', 0)
|
|
|
|
count_bytes = count_sectors * 512
|
|
bcfg = u_boot_console.config.buildconfig
|
|
has_cmd_memory = bcfg.get('config_cmd_memory', 'n') == 'y'
|
|
has_cmd_crc32 = bcfg.get('config_cmd_crc32', 'n') == 'y'
|
|
ram_base = u_boot_utils.find_ram_base(u_boot_console)
|
|
addr = '0x%08x' % ram_base
|
|
|
|
# Select MMC device
|
|
mmc_dev(u_boot_console, is_emmc, devid, partid)
|
|
|
|
# Clear target RAM
|
|
if expected_crc32:
|
|
if has_cmd_memory and has_cmd_crc32:
|
|
cmd = 'mw.b %s 0 0x%x' % (addr, count_bytes)
|
|
u_boot_console.run_command(cmd)
|
|
|
|
cmd = 'crc32 %s 0x%x' % (addr, count_bytes)
|
|
response = u_boot_console.run_command(cmd)
|
|
assert expected_crc32 not in response
|
|
else:
|
|
u_boot_console.log.warning(
|
|
'CONFIG_CMD_MEMORY or CONFIG_CMD_CRC32 != y: Skipping RAM clear')
|
|
|
|
# Read data
|
|
cmd = 'mmc read %s %x %x' % (addr, sector, count_sectors)
|
|
tstart = time.time()
|
|
response = u_boot_console.run_command(cmd)
|
|
tend = time.time()
|
|
good_response = 'MMC read: dev # %d, block # %d, count %d ... %d blocks read: OK' % (
|
|
devid, sector, count_sectors, count_sectors)
|
|
assert good_response in response
|
|
|
|
# Check target RAM
|
|
if expected_crc32:
|
|
if has_cmd_crc32:
|
|
cmd = 'crc32 %s 0x%x' % (addr, count_bytes)
|
|
response = u_boot_console.run_command(cmd)
|
|
assert expected_crc32 in response
|
|
else:
|
|
u_boot_console.log.warning('CONFIG_CMD_CRC32 != y: Skipping check')
|
|
|
|
# Check if the command did not take too long
|
|
if read_duration_max:
|
|
elapsed = tend - tstart
|
|
u_boot_console.log.info('Reading %d bytes took %f seconds' %
|
|
(count_bytes, elapsed))
|
|
assert elapsed <= (read_duration_max - 0.01)
|