mirror of
https://github.com/brain-hackers/u-boot-brain
synced 2024-08-31 06:18:51 +09:00
![Che-liang Chiou](/assets/img/avatar_default.png)
GNU Makefile have two flavors of variables, recursively expanded that is defined by using '=', and simply expanded that is defined by using ':='. The bug is caused by using recursively expanded flavor for BIN and SREC. As you can see below, they are prepended by $(obj) twice. We can reproduce this bug with a simplified version of this Makefile: $ cat >Makefile <<\EOF obj := /path/to/obj/ ELF := hello_world BIN_rec = $(addsuffix .bin,$(ELF)) # recursively expanded BIN_sim := $(addsuffix .bin,$(ELF)) # simply expanded ELF := $(addprefix $(obj),$(ELF)) BIN_rec := $(addprefix $(obj),$(BIN_rec)) BIN_sim := $(addprefix $(obj),$(BIN_sim)) show: @echo BIN_rec=$(BIN_rec) @echo BIN_sim=$(BIN_sim) .PHONY: show EOF $ make show BIN_rec=/path/to/obj//path/to/obj/hello_world.bin BIN_sim=/path/to/obj/hello_world.bin Signed-off-by: Che-Liang Chiou <clchiou@chromium.org>
118 lines
3.6 KiB
Makefile
118 lines
3.6 KiB
Makefile
#
|
|
# (C) Copyright 2000-2006
|
|
# Wolfgang Denk, DENX Software Engineering, wd@denx.de.
|
|
#
|
|
# See file CREDITS for list of people who contributed to this
|
|
# project.
|
|
#
|
|
# This program is free software; you can redistribute it and/or
|
|
# modify it under the terms of the GNU General Public License as
|
|
# published by the Free Software Foundation; either version 2 of
|
|
# the License, or (at your option) any later version.
|
|
#
|
|
# This program is distributed in the hope that it will be useful,
|
|
# but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
# GNU General Public License for more details.
|
|
#
|
|
# You should have received a copy of the GNU General Public License
|
|
# along with this program; if not, write to the Free Software
|
|
# Foundation, Inc., 59 Temple Place, Suite 330, Boston,
|
|
# MA 02111-1307 USA
|
|
#
|
|
|
|
include $(TOPDIR)/config.mk
|
|
|
|
ELF-$(ARCH) :=
|
|
ELF-$(BOARD) :=
|
|
ELF-$(CPU) :=
|
|
ELF-y := hello_world
|
|
|
|
ELF-$(CONFIG_SMC91111) += smc91111_eeprom
|
|
ELF-$(CONFIG_SMC911X) += smc911x_eeprom
|
|
ELF-$(CONFIG_SPI_FLASH_ATMEL) += atmel_df_pow2
|
|
ELF-i386 += 82559_eeprom
|
|
ELF-mpc5xxx += interrupt
|
|
ELF-mpc8xx += test_burst timer
|
|
ELF-mpc8260 += mem_to_mem_idma2intr
|
|
ELF-ppc += sched
|
|
ELF-oxc += eepro100_eeprom
|
|
|
|
#
|
|
# Some versions of make do not handle trailing white spaces properly;
|
|
# leading to build failures. The problem was found with GNU Make 3.80.
|
|
# Using 'strip' as a workaround for the problem.
|
|
#
|
|
ELF := $(strip $(ELF-y) $(ELF-$(ARCH)) $(ELF-$(BOARD)) $(ELF-$(CPU)))
|
|
|
|
SREC := $(addsuffix .srec,$(ELF))
|
|
BIN := $(addsuffix .bin,$(ELF))
|
|
|
|
COBJS := $(ELF:=.o)
|
|
|
|
LIB = $(obj)libstubs.o
|
|
|
|
LIBAOBJS-$(ARCH) :=
|
|
LIBAOBJS-$(CPU) :=
|
|
LIBAOBJS-ppc += $(ARCH)_longjmp.o $(ARCH)_setjmp.o
|
|
LIBAOBJS-mpc8xx += test_burst_lib.o
|
|
LIBAOBJS := $(LIBAOBJS-$(ARCH)) $(LIBAOBJS-$(CPU))
|
|
|
|
LIBCOBJS = stubs.o
|
|
|
|
LIBOBJS = $(addprefix $(obj),$(LIBAOBJS) $(LIBCOBJS))
|
|
|
|
SRCS := $(COBJS:.o=.c) $(LIBCOBJS:.o=.c) $(LIBAOBJS:.o=.S)
|
|
OBJS := $(addprefix $(obj),$(COBJS))
|
|
ELF := $(addprefix $(obj),$(ELF))
|
|
BIN := $(addprefix $(obj),$(BIN))
|
|
SREC := $(addprefix $(obj),$(SREC))
|
|
|
|
gcclibdir := $(shell dirname `$(CC) -print-libgcc-file-name`)
|
|
|
|
CPPFLAGS += -I..
|
|
|
|
# For PowerPC there's no need to compile standalone applications as a
|
|
# relocatable executable. The relocation data is not needed, and
|
|
# also causes the entry point of the standalone application to be
|
|
# inconsistent.
|
|
ifeq ($(ARCH),powerpc)
|
|
AFLAGS := $(filter-out $(RELFLAGS),$(AFLAGS))
|
|
CFLAGS := $(filter-out $(RELFLAGS),$(CFLAGS))
|
|
CPPFLAGS := $(filter-out $(RELFLAGS),$(CPPFLAGS))
|
|
endif
|
|
|
|
# We don't want gcc reordering functions if possible. This ensures that an
|
|
# application's entry point will be the first function in the application's
|
|
# source file.
|
|
CFLAGS += $(call cc-option,-fno-toplevel-reorder)
|
|
|
|
all: $(obj).depend $(OBJS) $(LIB) $(SREC) $(BIN) $(ELF)
|
|
|
|
#########################################################################
|
|
$(LIB): $(obj).depend $(LIBOBJS)
|
|
$(call cmd_link_o_target, $(LIBOBJS))
|
|
|
|
$(ELF):
|
|
$(obj)%: $(obj)%.o $(LIB)
|
|
$(LD) -g -Ttext $(CONFIG_STANDALONE_LOAD_ADDR) \
|
|
-o $@ -e $(SYM_PREFIX)$(notdir $(<:.o=)) $< $(LIB) \
|
|
-L$(gcclibdir) -lgcc
|
|
|
|
$(SREC):
|
|
$(obj)%.srec: $(obj)%
|
|
$(OBJCOPY) -O srec $< $@ 2>/dev/null
|
|
|
|
$(BIN):
|
|
$(obj)%.bin: $(obj)%
|
|
$(OBJCOPY) -O binary $< $@ 2>/dev/null
|
|
|
|
#########################################################################
|
|
|
|
# defines $(obj).depend target
|
|
include $(SRCTREE)/rules.mk
|
|
|
|
sinclude $(obj).depend
|
|
|
|
#########################################################################
|