mirror of
https://github.com/brain-hackers/u-boot-brain
synced 2024-08-31 06:18:51 +09:00
![Rob Herring](/assets/img/avatar_default.png)
CHUNK_TYPE_DONT_CARE should skip over the specified number of blocks, but currently fails to increment the device block address. This results in filesystem images getting written incorrectly. Add the missing block address incrementing. Cc: Steve Rae <srae@broadcom.com> Signed-off-by: Rob Herring <robh@kernel.org> Reviewed-by: Steve Rae <srae@broadcom.com>
245 lines
7.2 KiB
C
245 lines
7.2 KiB
C
/*
|
|
* Copyright (c) 2009, Google Inc.
|
|
* All rights reserved.
|
|
*
|
|
* Copyright (c) 2009-2014, The Linux Foundation. All rights reserved.
|
|
* Portions Copyright 2014 Broadcom Corporation.
|
|
*
|
|
* Redistribution and use in source and binary forms, with or without
|
|
* modification, are permitted provided that the following conditions are met:
|
|
* * Redistributions of source code must retain the above copyright
|
|
* notice, this list of conditions and the following disclaimer.
|
|
* * Redistributions in binary form must reproduce the above copyright
|
|
* notice, this list of conditions and the following disclaimer in the
|
|
* documentation and/or other materials provided with the distribution.
|
|
* * Neither the name of The Linux Foundation nor
|
|
* the names of its contributors may be used to endorse or promote
|
|
* products derived from this software without specific prior written
|
|
* permission.
|
|
*
|
|
* THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS"
|
|
* AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
|
|
* IMPLIED WARRANTIES OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
|
|
* NON-INFRINGEMENT ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT OWNER OR
|
|
* CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL,
|
|
* EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO,
|
|
* PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS;
|
|
* OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY,
|
|
* WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR
|
|
* OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF
|
|
* ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
|
|
*
|
|
* NOTE:
|
|
* Although it is very similar, this license text is not identical
|
|
* to the "BSD-3-Clause", therefore, DO NOT MODIFY THIS LICENSE TEXT!
|
|
*/
|
|
|
|
#include <config.h>
|
|
#include <common.h>
|
|
#include <aboot.h>
|
|
#include <malloc.h>
|
|
#include <part.h>
|
|
#include <sparse_format.h>
|
|
|
|
void write_sparse_image(block_dev_desc_t *dev_desc,
|
|
disk_partition_t *info, const char *part_name,
|
|
void *data, unsigned sz)
|
|
{
|
|
lbaint_t blk;
|
|
lbaint_t blkcnt;
|
|
lbaint_t blks;
|
|
uint32_t bytes_written = 0;
|
|
unsigned int chunk;
|
|
unsigned int chunk_data_sz;
|
|
uint32_t *fill_buf = NULL;
|
|
uint32_t fill_val;
|
|
sparse_header_t *sparse_header;
|
|
chunk_header_t *chunk_header;
|
|
uint32_t total_blocks = 0;
|
|
int i;
|
|
|
|
/* Read and skip over sparse image header */
|
|
sparse_header = (sparse_header_t *) data;
|
|
|
|
data += sparse_header->file_hdr_sz;
|
|
if (sparse_header->file_hdr_sz > sizeof(sparse_header_t))
|
|
{
|
|
/*
|
|
* Skip the remaining bytes in a header that is longer than
|
|
* we expected.
|
|
*/
|
|
data += (sparse_header->file_hdr_sz - sizeof(sparse_header_t));
|
|
}
|
|
|
|
debug("=== Sparse Image Header ===\n");
|
|
debug("magic: 0x%x\n", sparse_header->magic);
|
|
debug("major_version: 0x%x\n", sparse_header->major_version);
|
|
debug("minor_version: 0x%x\n", sparse_header->minor_version);
|
|
debug("file_hdr_sz: %d\n", sparse_header->file_hdr_sz);
|
|
debug("chunk_hdr_sz: %d\n", sparse_header->chunk_hdr_sz);
|
|
debug("blk_sz: %d\n", sparse_header->blk_sz);
|
|
debug("total_blks: %d\n", sparse_header->total_blks);
|
|
debug("total_chunks: %d\n", sparse_header->total_chunks);
|
|
|
|
/* verify sparse_header->blk_sz is an exact multiple of info->blksz */
|
|
if (sparse_header->blk_sz !=
|
|
(sparse_header->blk_sz & ~(info->blksz - 1))) {
|
|
printf("%s: Sparse image block size issue [%u]\n",
|
|
__func__, sparse_header->blk_sz);
|
|
fastboot_fail("sparse image block size issue");
|
|
return;
|
|
}
|
|
|
|
puts("Flashing Sparse Image\n");
|
|
|
|
/* Start processing chunks */
|
|
blk = info->start;
|
|
for (chunk=0; chunk<sparse_header->total_chunks; chunk++)
|
|
{
|
|
/* Read and skip over chunk header */
|
|
chunk_header = (chunk_header_t *) data;
|
|
data += sizeof(chunk_header_t);
|
|
|
|
if (chunk_header->chunk_type != CHUNK_TYPE_RAW) {
|
|
debug("=== Chunk Header ===\n");
|
|
debug("chunk_type: 0x%x\n", chunk_header->chunk_type);
|
|
debug("chunk_data_sz: 0x%x\n", chunk_header->chunk_sz);
|
|
debug("total_size: 0x%x\n", chunk_header->total_sz);
|
|
}
|
|
|
|
if (sparse_header->chunk_hdr_sz > sizeof(chunk_header_t))
|
|
{
|
|
/*
|
|
* Skip the remaining bytes in a header that is longer
|
|
* than we expected.
|
|
*/
|
|
data += (sparse_header->chunk_hdr_sz -
|
|
sizeof(chunk_header_t));
|
|
}
|
|
|
|
chunk_data_sz = sparse_header->blk_sz * chunk_header->chunk_sz;
|
|
blkcnt = chunk_data_sz / info->blksz;
|
|
switch (chunk_header->chunk_type)
|
|
{
|
|
case CHUNK_TYPE_RAW:
|
|
if (chunk_header->total_sz !=
|
|
(sparse_header->chunk_hdr_sz + chunk_data_sz))
|
|
{
|
|
fastboot_fail(
|
|
"Bogus chunk size for chunk type Raw");
|
|
return;
|
|
}
|
|
|
|
if (blk + blkcnt > info->start + info->size) {
|
|
printf(
|
|
"%s: Request would exceed partition size!\n",
|
|
__func__);
|
|
fastboot_fail(
|
|
"Request would exceed partition size!");
|
|
return;
|
|
}
|
|
|
|
blks = dev_desc->block_write(dev_desc->dev, blk, blkcnt,
|
|
data);
|
|
if (blks != blkcnt) {
|
|
printf("%s: Write failed " LBAFU "\n",
|
|
__func__, blks);
|
|
fastboot_fail("flash write failure");
|
|
return;
|
|
}
|
|
blk += blkcnt;
|
|
bytes_written += blkcnt * info->blksz;
|
|
total_blocks += chunk_header->chunk_sz;
|
|
data += chunk_data_sz;
|
|
break;
|
|
|
|
case CHUNK_TYPE_FILL:
|
|
if (chunk_header->total_sz !=
|
|
(sparse_header->chunk_hdr_sz + sizeof(uint32_t)))
|
|
{
|
|
fastboot_fail(
|
|
"Bogus chunk size for chunk type FILL");
|
|
return;
|
|
}
|
|
|
|
fill_buf = (uint32_t *)
|
|
memalign(ARCH_DMA_MINALIGN,
|
|
ROUNDUP(info->blksz,
|
|
ARCH_DMA_MINALIGN));
|
|
if (!fill_buf)
|
|
{
|
|
fastboot_fail(
|
|
"Malloc failed for: CHUNK_TYPE_FILL");
|
|
return;
|
|
}
|
|
|
|
fill_val = *(uint32_t *)data;
|
|
data = (char *) data + sizeof(uint32_t);
|
|
|
|
for (i = 0; i < (info->blksz / sizeof(fill_val)); i++)
|
|
fill_buf[i] = fill_val;
|
|
|
|
if (blk + blkcnt > info->start + info->size) {
|
|
printf(
|
|
"%s: Request would exceed partition size!\n",
|
|
__func__);
|
|
fastboot_fail(
|
|
"Request would exceed partition size!");
|
|
return;
|
|
}
|
|
|
|
for (i = 0; i < blkcnt; i++) {
|
|
blks = dev_desc->block_write(dev_desc->dev,
|
|
blk, 1, fill_buf);
|
|
if (blks != 1) {
|
|
printf(
|
|
"%s: Write failed, block # " LBAFU "\n",
|
|
__func__, blkcnt);
|
|
fastboot_fail("flash write failure");
|
|
free(fill_buf);
|
|
return;
|
|
}
|
|
blk++;
|
|
}
|
|
bytes_written += blkcnt * info->blksz;
|
|
total_blocks += chunk_data_sz / sparse_header->blk_sz;
|
|
|
|
free(fill_buf);
|
|
break;
|
|
|
|
case CHUNK_TYPE_DONT_CARE:
|
|
blk += blkcnt;
|
|
total_blocks += chunk_header->chunk_sz;
|
|
break;
|
|
|
|
case CHUNK_TYPE_CRC32:
|
|
if (chunk_header->total_sz !=
|
|
sparse_header->chunk_hdr_sz)
|
|
{
|
|
fastboot_fail(
|
|
"Bogus chunk size for chunk type Dont Care");
|
|
return;
|
|
}
|
|
total_blocks += chunk_header->chunk_sz;
|
|
data += chunk_data_sz;
|
|
break;
|
|
|
|
default:
|
|
printf("%s: Unknown chunk type: %x\n", __func__,
|
|
chunk_header->chunk_type);
|
|
fastboot_fail("Unknown chunk type");
|
|
return;
|
|
}
|
|
}
|
|
|
|
debug("Wrote %d blocks, expected to write %d blocks\n",
|
|
total_blocks, sparse_header->total_blks);
|
|
printf("........ wrote %u bytes to '%s'\n", bytes_written, part_name);
|
|
|
|
if (total_blocks != sparse_header->total_blks)
|
|
fastboot_fail("sparse image write failure");
|
|
|
|
fastboot_okay("");
|
|
return;
|
|
}
|