mirror of
https://github.com/brain-hackers/u-boot-brain
synced 2024-09-08 13:53:21 +09:00
![]() The Linux coding style guide (Documentation/process/coding-style.rst) clearly says: It's a **mistake** to use typedef for structures and pointers. Besides, using typedef for structures is annoying when you try to make headers self-contained. Let's say you have the following function declaration in a header: void foo(bd_t *bd); This is not self-contained since bd_t is not defined. To tell the compiler what 'bd_t' is, you need to include <asm/u-boot.h> #include <asm/u-boot.h> void foo(bd_t *bd); Then, the include direcective pulls in more bloat needlessly. If you use 'struct bd_info' instead, it is enough to put a forward declaration as follows: struct bd_info; void foo(struct bd_info *bd); Right, typedef'ing bd_t is a mistake. I used coccinelle to generate this commit. The semantic patch that makes this change is as follows: <smpl> @@ typedef bd_t; @@ -bd_t +struct bd_info </smpl> Signed-off-by: Masahiro Yamada <masahiroy@kernel.org> |
||
---|---|---|
.. | ||
bcm235xx | ||
bcm281xx | ||
bcmcygnus | ||
bcmnsp | ||
iproc-common | ||
kona-common | ||
ls102xa | ||
s5p-common | ||
stv0991 | ||
sunxi | ||
vf610 | ||
arch_timer.c | ||
cache_v7_asm.S | ||
cache_v7.c | ||
config.mk | ||
cp15.c | ||
cpu.c | ||
exception_level.c | ||
Kconfig | ||
lowlevel_init.S | ||
Makefile | ||
mpu_v7r.c | ||
nonsec_virt.S | ||
psci-common.c | ||
psci.S | ||
sctlr.S | ||
smccc-call.S | ||
start.S | ||
syslib.c | ||
virt-dt.c | ||
virt-v7.c |