mirror of
https://github.com/brain-hackers/u-boot-brain
synced 2024-08-28 21:09:00 +09:00
![Masahiro Yamada](/assets/img/avatar_default.png)
The Linux coding style guide (Documentation/process/coding-style.rst) clearly says: It's a **mistake** to use typedef for structures and pointers. Besides, using typedef for structures is annoying when you try to make headers self-contained. Let's say you have the following function declaration in a header: void foo(bd_t *bd); This is not self-contained since bd_t is not defined. To tell the compiler what 'bd_t' is, you need to include <asm/u-boot.h> #include <asm/u-boot.h> void foo(bd_t *bd); Then, the include direcective pulls in more bloat needlessly. If you use 'struct bd_info' instead, it is enough to put a forward declaration as follows: struct bd_info; void foo(struct bd_info *bd); Right, typedef'ing bd_t is a mistake. I used coccinelle to generate this commit. The semantic patch that makes this change is as follows: <smpl> @@ typedef bd_t; @@ -bd_t +struct bd_info </smpl> Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
30 lines
767 B
C
30 lines
767 B
C
/* SPDX-License-Identifier: GPL-2.0+ */
|
|
/*
|
|
* Copyright (C) 2013, 2014 TQ Systems
|
|
* Author: Markus Niebel <markus.niebel@tq-group.com>
|
|
*/
|
|
|
|
#ifndef __TQMA6_BB__
|
|
#define __TQMA6_BB__
|
|
|
|
#include <common.h>
|
|
|
|
int tqma6_bb_board_mmc_getwp(struct mmc *mmc);
|
|
int tqma6_bb_board_mmc_getcd(struct mmc *mmc);
|
|
int tqma6_bb_board_mmc_init(struct bd_info *bis);
|
|
|
|
int tqma6_bb_board_early_init_f(void);
|
|
int tqma6_bb_board_init(void);
|
|
int tqma6_bb_board_late_init(void);
|
|
int tqma6_bb_checkboard(void);
|
|
|
|
const char *tqma6_bb_get_boardname(void);
|
|
/*
|
|
* Device Tree Support
|
|
*/
|
|
#if defined(CONFIG_OF_BOARD_SETUP) && defined(CONFIG_OF_LIBFDT)
|
|
void tqma6_bb_ft_board_setup(void *blob, struct bd_info *bd);
|
|
#endif /* defined(CONFIG_OF_BOARD_SETUP) && defined(CONFIG_OF_LIBFDT) */
|
|
|
|
#endif
|