mirror of
https://github.com/brain-hackers/u-boot-brain
synced 2024-10-04 18:40:42 +09:00
54841ab50c
The hush shell dynamically allocates (and re-allocates) memory for the argument strings in the "char *argv[]" argument vector passed to commands. Any code that modifies these pointers will cause serious corruption of the malloc data structures and crash U-Boot, so make sure the compiler can check that no such modifications are being done by changing the code into "char * const argv[]". This modification is the result of debugging a strange crash caused after adding a new command, which used the following argument processing code which has been working perfectly fine in all Unix systems since version 6 - but not so in U-Boot: int main (int argc, char **argv) { while (--argc > 0 && **++argv == '-') { /* ====> */ while (*++*argv) { switch (**argv) { case 'd': debug++; break; ... default: usage (); } } } ... } The line marked "====>" will corrupt the malloc data structures and usually cause U-Boot to crash when the next command gets executed by the shell. With the modification, the compiler will prevent this with an error: increment of read-only location '*argv' N.B.: The code above can be trivially rewritten like this: while (--argc > 0 && **++argv == '-') { char *arg = *argv; while (*++arg) { switch (*arg) { ... Signed-off-by: Wolfgang Denk <wd@denx.de> Acked-by: Mike Frysinger <vapier@gentoo.org> |
||
---|---|---|
.. | ||
common | ||
m547xevb | ||
m548xevb | ||
m5208evbe | ||
m5235evb | ||
m5249evb | ||
m5253demo | ||
m5253evbe | ||
m5271evb | ||
m5272c3 | ||
m5275evb | ||
m5282evb | ||
m5329evb | ||
m5373evb | ||
m52277evb | ||
m53017evb | ||
m54451evb | ||
m54455evb | ||
mpc832xemds | ||
mpc837xemds | ||
mpc837xerdb | ||
mpc5121ads | ||
mpc7448hpc2 | ||
mpc8260ads | ||
mpc8266ads | ||
mpc8313erdb | ||
mpc8315erdb | ||
mpc8323erdb | ||
mpc8349emds | ||
mpc8349itx | ||
mpc8360emds | ||
mpc8360erdk | ||
mpc8536ds | ||
mpc8540ads | ||
mpc8541cds | ||
mpc8544ds | ||
mpc8548cds | ||
mpc8555cds | ||
mpc8560ads | ||
mpc8568mds | ||
mpc8569mds | ||
mpc8572ds | ||
mpc8610hpcd | ||
mpc8641hpcn | ||
mx31ads | ||
mx31pdk | ||
mx51evk | ||
p1_p2_rdb | ||
p2020ds |