mirror of
https://github.com/brain-hackers/u-boot-brain
synced 2024-07-12 06:06:15 +09:00
54841ab50c
The hush shell dynamically allocates (and re-allocates) memory for the
argument strings in the "char *argv[]" argument vector passed to
commands. Any code that modifies these pointers will cause serious
corruption of the malloc data structures and crash U-Boot, so make
sure the compiler can check that no such modifications are being done
by changing the code into "char * const argv[]".
This modification is the result of debugging a strange crash caused
after adding a new command, which used the following argument
processing code which has been working perfectly fine in all Unix
systems since version 6 - but not so in U-Boot:
int main (int argc, char **argv)
{
while (--argc > 0 && **++argv == '-') {
/* ====> */ while (*++*argv) {
switch (**argv) {
case 'd':
debug++;
break;
...
default:
usage ();
}
}
}
...
}
The line marked "====>" will corrupt the malloc data structures and
usually cause U-Boot to crash when the next command gets executed by
the shell. With the modification, the compiler will prevent this with
an
error: increment of read-only location '*argv'
N.B.: The code above can be trivially rewritten like this:
while (--argc > 0 && **++argv == '-') {
char *arg = *argv;
while (*++arg) {
switch (*arg) {
...
Signed-off-by: Wolfgang Denk <wd@denx.de>
Acked-by: Mike Frysinger <vapier@gentoo.org>
35 lines
755 B
C
35 lines
755 B
C
/*
|
|
* flash.c - helper commands for working with GPIO-assisted flash
|
|
*
|
|
* Copyright (c) 2005-2009 Analog Devices Inc.
|
|
*
|
|
* Licensed under the GPL-2 or later.
|
|
*/
|
|
|
|
#include <common.h>
|
|
#include <command.h>
|
|
#include <asm/blackfin.h>
|
|
#include "gpio_cfi_flash.h"
|
|
|
|
int do_ph(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
|
|
{
|
|
ulong faddr = CONFIG_SYS_FLASH_BASE;
|
|
ushort data;
|
|
ulong dflg;
|
|
|
|
if (argc > 1) {
|
|
dflg = simple_strtoul(argv[1], NULL, 16);
|
|
faddr |= (dflg << 21);
|
|
gpio_cfi_flash_swizzle((void *)faddr);
|
|
} else {
|
|
data = bfin_read_PORTHIO();
|
|
printf("Port H data %04x (PH0:%i)\n", data, !!(data & PH0));
|
|
}
|
|
|
|
return 0;
|
|
}
|
|
|
|
U_BOOT_CMD(ph, 3, 0, do_ph,
|
|
"set/clear PH0 GPIO flash bank switch\n",
|
|
"<ph0> - set PH0 GPIO pin state\n");
|