mirror of
https://github.com/brain-hackers/u-boot-brain
synced 2024-06-09 23:36:03 +09:00
e3245e4254
When a driver declares DM_FLAG_PRE_RELOC flag, it wishes to be bound before relocation. However due to a bug in the DM core, the flag only takes effect when devices are statically declared via U_BOOT_DEVICE(). This bug has been fixed recently by commit "dm: core: Respect drivers with the DM_FLAG_PRE_RELOC flag in lists_bind_fdt()", but with the fix, it has a side effect that all existing drivers that declared DM_FLAG_PRE_RELOC flag will be bound before relocation now. This may expose potential boot failure on some boards due to insufficient memory during the pre-relocation stage. To mitigate this potential impact, the following changes are implemented: - Remove DM_FLAG_PRE_RELOC flag in the driver, if the driver only supports configuration from device tree (OF_CONTROL) - Keep DM_FLAG_PRE_RELOC flag in the driver only if the device is statically declared via U_BOOT_DEVICE() - Surround DM_FLAG_PRE_RELOC flag with OF_CONTROL check, for drivers that support both statically declared devices and configuration from device tree Signed-off-by: Bin Meng <bmeng.cn@gmail.com> Reviewed-by: Simon Glass <sjg@chromium.org>
72 lines
1.7 KiB
C
72 lines
1.7 KiB
C
// SPDX-License-Identifier: GPL-2.0+
|
|
/*
|
|
* (C) Copyright 2017 Rob Clark
|
|
*/
|
|
|
|
#include <common.h>
|
|
#include <dm.h>
|
|
#include <fdtdec.h>
|
|
#include <fdt_support.h>
|
|
#include <video.h>
|
|
|
|
static int simple_video_probe(struct udevice *dev)
|
|
{
|
|
struct video_uc_platdata *plat = dev_get_uclass_platdata(dev);
|
|
struct video_priv *uc_priv = dev_get_uclass_priv(dev);
|
|
const void *blob = gd->fdt_blob;
|
|
const int node = dev_of_offset(dev);
|
|
const char *format;
|
|
fdt_addr_t base;
|
|
fdt_size_t size;
|
|
|
|
base = fdtdec_get_addr_size_auto_parent(blob, dev_of_offset(dev->parent),
|
|
node, "reg", 0, &size, false);
|
|
if (base == FDT_ADDR_T_NONE) {
|
|
debug("%s: Failed to decode memory region\n", __func__);
|
|
return -EINVAL;
|
|
}
|
|
|
|
debug("%s: base=%llx, size=%llu\n", __func__, base, size);
|
|
|
|
/*
|
|
* TODO is there some way to reserve the framebuffer
|
|
* region so it isn't clobbered?
|
|
*/
|
|
plat->base = base;
|
|
plat->size = size;
|
|
|
|
video_set_flush_dcache(dev, true);
|
|
|
|
debug("%s: Query resolution...\n", __func__);
|
|
|
|
uc_priv->xsize = fdtdec_get_uint(blob, node, "width", 0);
|
|
uc_priv->ysize = fdtdec_get_uint(blob, node, "height", 0);
|
|
uc_priv->rot = 0;
|
|
|
|
format = fdt_getprop(blob, node, "format", NULL);
|
|
debug("%s: %dx%d@%s\n", __func__, uc_priv->xsize, uc_priv->ysize, format);
|
|
|
|
if (strcmp(format, "r5g6b5") == 0) {
|
|
uc_priv->bpix = VIDEO_BPP16;
|
|
} else if (strcmp(format, "a8b8g8r8") == 0) {
|
|
uc_priv->bpix = VIDEO_BPP32;
|
|
} else {
|
|
printf("%s: invalid format: %s\n", __func__, format);
|
|
return -EINVAL;
|
|
}
|
|
|
|
return 0;
|
|
}
|
|
|
|
static const struct udevice_id simple_video_ids[] = {
|
|
{ .compatible = "simple-framebuffer" },
|
|
{ }
|
|
};
|
|
|
|
U_BOOT_DRIVER(simple_video) = {
|
|
.name = "simple_video",
|
|
.id = UCLASS_VIDEO,
|
|
.of_match = simple_video_ids,
|
|
.probe = simple_video_probe,
|
|
};
|