mirror of
https://github.com/brain-hackers/u-boot-brain
synced 2024-08-20 08:58:52 +09:00
![Masahiro Yamada](/assets/img/avatar_default.png)
U-Boot widely uses error() as a bit noisier variant of printf(). This macro causes name conflict with the following line in include/linux/compiler-gcc.h: # define __compiletime_error(message) __attribute__((error(message))) This prevents us from using __compiletime_error(), and makes it difficult to fully sync BUILD_BUG macros with Linux. (Notice Linux's BUILD_BUG_ON_MSG is implemented by using compiletime_assert().) Let's convert error() into now treewide-available pr_err(). Done with the help of Coccinelle, excluing tools/ directory. The semantic patch I used is as follows: // <smpl> @@@@ -error +pr_err (...) // </smpl> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com> Reviewed-by: Simon Glass <sjg@chromium.org> [trini: Re-run Coccinelle] Signed-off-by: Tom Rini <trini@konsulko.com>
38 lines
778 B
C
38 lines
778 B
C
/*
|
|
* (C) Copyright 2016 Toradex
|
|
* Author: Stefan Agner <stefan.agner@toradex.com>
|
|
*
|
|
* SPDX-License-Identifier: GPL-2.0+
|
|
*/
|
|
|
|
#include <common.h>
|
|
#include <spl.h>
|
|
#include <usb.h>
|
|
#include <g_dnl.h>
|
|
#include <sdp.h>
|
|
|
|
DECLARE_GLOBAL_DATA_PTR;
|
|
|
|
static int spl_sdp_load_image(struct spl_image_info *spl_image,
|
|
struct spl_boot_device *bootdev)
|
|
{
|
|
int ret;
|
|
const int controller_index = 0;
|
|
|
|
g_dnl_clear_detach();
|
|
g_dnl_register("usb_dnl_sdp");
|
|
|
|
ret = sdp_init(controller_index);
|
|
if (ret) {
|
|
pr_err("SDP init failed: %d", ret);
|
|
return -ENODEV;
|
|
}
|
|
|
|
/* This command typically does not return but jumps to an image */
|
|
sdp_handle(controller_index);
|
|
pr_err("SDP ended");
|
|
|
|
return -EINVAL;
|
|
}
|
|
SPL_LOAD_IMAGE_METHOD("USB SDP", 0, BOOT_DEVICE_BOARD, spl_sdp_load_image);
|