Tom Rini 59ee8f83b6 cmd/pxe.c: Rework bootargs construction to clarify string checks ... As the code currently stands, we first check that the length of the given command line, along with ip_str/mac_str along with an additional 1 for the NULL termination will fit within the buffer we have, and if not, we return an error. The way this code was originally written however left Coverity "unhappy" due to using strcat rather than strncat. Switching this to strncat however causes clang to be unhappy that we aren't enforcing the "1" portion within strncat. Rather than further re-work the code to include a "- 1" in this case as well, make the strcat code only be done within the else side of the length test. This keeps both clang and Coverity happy. Fixes: 48ee0a87bc ("cmd/pxe.c: Rework initrd and bootargs handling slightly") Signed-off-by: Tom Rini <trini@konsulko.com>		2017-10-16 09:42:51 -04:00
..
fastboot	sunxi: Remove the MMC index hack	2017-10-03 19:12:06 +02:00
mvebu	env: Rename getenv/_f() to env_get()	2017-08-16 08:30:24 -04:00
.gitignore
aes.c	Rename aes.h to uboot_aes.h	2017-04-12 13:28:27 -04:00
armflash.c
bdinfo.c	env: Rename getenv/_f() to env_get()	2017-08-16 08:30:24 -04:00
bedbug.c	powerpc: remove 4xx support	2017-07-03 17:35:28 -04:00
blk_common.c	cmd: blk: Use LBAFU in the common block command	2017-09-15 08:05:10 -04:00
blkcache.c
blob.c
bmp.c
boot.c
bootefi.c	efi_loader: Add mem-mapped for fallback	2017-10-12 17:22:58 +02:00
booti.c
bootm.c	env: Rename getenv/_f() to env_get()	2017-08-16 08:30:24 -04:00
bootmenu.c	env: Rename getenv/_f() to env_get()	2017-08-16 08:30:24 -04:00
bootstage.c
bootz.c
btrfs.c	cmd: Add the 'btrsubvol' command to list BTRFS subvolumes	2017-10-02 21:52:18 -04:00
cache.c
cbfs.c	env: Rename common functions related to setenv()	2017-08-16 08:23:32 -04:00
clk.c
config.c
console.c
cpu.c	cmd: cpu: refactor to ensure devices are probed and improve code style	2017-05-10 16:16:09 +02:00
cramfs.c	env: Rename getenv/_f() to env_get()	2017-08-16 08:30:24 -04:00
cros_ec.c	dm: core: Add flags parameter to device_remove()	2017-04-04 20:15:10 -06:00
dataflash_mmc_mux.c
date.c
demo.c
dfu.c
diag.c
disk.c
display.c
echo.c
eeprom.c	Convert CONFIG_CMD_EEPROM et al to Kconfig	2017-05-22 09:33:49 -04:00
efi.c
elf.c	env: Rename some other getenv()-related functions	2017-08-16 08:31:11 -04:00
ethsw.c	cmd: ethsw: Fix out-of-bounds error	2017-06-16 10:11:42 -04:00
exit.c
ext2.c
ext4.c
fastboot.c	treewide: replace with error() with pr_err()	2017-10-04 11:59:44 -04:00
fat.c
fdc.c
fdt.c	fdt: Switch to using the verbose overlay application method	2017-09-15 05:27:48 -06:00
fitupd.c
flash.c	Drop CONFIG_HAS_DATAFLASH	2017-10-16 09:42:51 -04:00
fpga.c	env: Rename getenv/_f() to env_get()	2017-08-16 08:30:24 -04:00
fpgad.c
fs_uuid.c
fs.c
fuse.c
gettime.c
gpio.c
gpt.c	cmd/gpt.c, cmd/nvedit.c, tools/fit_image.c: Rework recent fixes for Coverity	2017-10-07 11:27:59 -04:00
hash.c
help.c
host.c
i2c.c
ide.c	cmd: ide: Make the first device the default one	2017-09-10 12:27:43 -04:00
ini.c	env: Rename getenv/_f() to env_get()	2017-08-16 08:30:24 -04:00
io.c	cmd/io.c: Fix comparison of unsigned expression warning	2017-05-12 08:37:38 -04:00
iotrace.c
irq.c
itest.c	env: Rename getenv/_f() to env_get()	2017-08-16 08:30:24 -04:00
jffs2.c	env: Rename getenv/_f() to env_get()	2017-08-16 08:30:24 -04:00
Kconfig	cmd: Toggle the default value of CONFIG_CMD_IMLS	2017-10-10 17:51:04 -04:00
led.c	cmd/led.c: Remove unnecessary check on 'cmd' value	2017-05-12 08:37:38 -04:00
legacy_led.c	led: Mark existing driver as legacy	2017-04-14 19:38:57 -06:00
license.c
load.c	env: Rename getenv/_f() to env_get()	2017-08-16 08:30:24 -04:00
log.c	env: Rename getenv/_f() to env_get()	2017-08-16 08:30:24 -04:00
lzmadec.c	env: Rename common functions related to setenv()	2017-08-16 08:23:32 -04:00
mac.c
Makefile	cmd: Add the 'btrsubvol' command to list BTRFS subvolumes	2017-10-02 21:52:18 -04:00
md5sum.c	env: Rename getenv/_f() to env_get()	2017-08-16 08:30:24 -04:00
mdio.c
mem.c	Drop CONFIG_HAS_DATAFLASH	2017-10-16 09:42:51 -04:00
mfsl.c
mii.c
misc.c
mmc_spi.c
mmc.c	blk: Remove various places that do flush cache after read	2017-09-15 08:05:10 -04:00
mp.c
mtdparts.c	mtdparts: Fix uninitialized scalar usage	2017-08-26 16:59:24 -04:00
nand.c	env: Rename getenv/_f() to env_get()	2017-08-16 08:30:24 -04:00
net.c	env: Rename some other getenv()-related functions	2017-08-16 08:31:11 -04:00
nvedit.c	env: Drop CONFIG_ENV_IS_IN_DATAFLASH	2017-10-16 09:42:51 -04:00
nvme.c	nvme: Adjust the 'nvme' command to use blk_common_cmd()	2017-08-28 07:17:15 -04:00
onenand.c
part.c	env: Rename setenv() to env_set()	2017-08-16 08:22:18 -04:00
pci.c	Kconfig: Drop CONFIG_CMD_PCI_ENUM	2017-08-11 15:41:51 -04:00
pcmcia.c	powerpc, 8xx: remove support for 8xx	2017-06-12 08:37:55 -04:00
pmic.c
pxe.c	cmd/pxe.c: Rework bootargs construction to clarify string checks	2017-10-16 09:42:51 -04:00
qfw.c	env: Rename getenv/_f() to env_get()	2017-08-16 08:30:24 -04:00
read.c	cmd/read.c: Fix checking blk_dread return value	2017-08-20 09:54:30 -04:00
reginfo.c	powerpc: Remove unneccessary #ifdefs in reginfo	2017-07-22 22:22:49 -04:00
regulator.c	treewide: replace with error() with pr_err()	2017-10-04 11:59:44 -04:00
reiser.c	env: Rename getenv/_f() to env_get()	2017-08-16 08:30:24 -04:00
remoteproc.c
sata.c	dm: sata: Support driver model with the 'sata' command	2017-08-17 16:44:17 +09:00
scsi.c	dm: scsi: Adjust the 'scsi' command to use blk_common_cmd()	2017-08-17 16:44:16 +09:00
setexpr.c	env: Rename getenv/_f() to env_get()	2017-08-16 08:30:24 -04:00
sf.c	dm: core: Add flags parameter to device_remove()	2017-04-04 20:15:10 -06:00
sha1sum.c
sound.c
source.c	env: Rename getenv_hex(), getenv_yesno(), getenv_ulong()	2017-08-16 08:30:32 -04:00
spi.c
spl.c	cmd: spl: fix compiling error when CONFIG_CMD_SPL_WRITE_SIZE not defined	2017-10-09 08:48:44 -07:00
strings.c
terminal.c
test.c
thordown.c	treewide: replace with error() with pr_err()	2017-10-04 11:59:44 -04:00
time.c	cmd/time.c: Initialize 'repeatable' variable	2017-10-06 11:28:21 -04:00
tpm_test.c	treewide: replace with error() with pr_err()	2017-10-04 11:59:44 -04:00
tpm.c	env: Rename common functions related to setenv()	2017-08-16 08:23:32 -04:00
trace.c	env: Rename getenv_hex(), getenv_yesno(), getenv_ulong()	2017-08-16 08:30:32 -04:00
tsi148.c
ubi.c	cmd: set filesize variable in ubi read	2017-09-12 10:08:05 +02:00
ubifs.c
universe.c
unzip.c	env: Rename common functions related to setenv()	2017-08-16 08:23:32 -04:00
usb_gadget_sdp.c	treewide: replace with error() with pr_err()	2017-10-04 11:59:44 -04:00
usb_mass_storage.c	treewide: replace with error() with pr_err()	2017-10-04 11:59:44 -04:00
usb.c	dm: usb: Adjust the 'usb' command to use blk_common_cmd()	2017-08-17 16:44:16 +09:00
version.c	display_options: Refactor to allow obtaining the banner	2017-07-11 10:08:19 -06:00
ximg.c	env: Rename getenv_hex(), getenv_yesno(), getenv_ulong()	2017-08-16 08:30:32 -04:00
yaffs2.c
zfs.c	env: Rename getenv/_f() to env_get()	2017-08-16 08:30:24 -04:00
zip.c	env: Rename common functions related to setenv()	2017-08-16 08:23:32 -04:00