mirror of
https://github.com/brain-hackers/u-boot-brain
synced 2024-06-09 23:36:03 +09:00
17fa032671
commit: 65f83802b7 "serial: 16550: Add getfcr accessor"
breaks u-boot commandline working with long commands
sending to the board.
Since the above patch, you have to setup the fcr register.
For board/archs which enable OF_PLATDATA, the new field
fcr in struct ns16550_platdata is not filled with a
default value ...
This leads in not setting up the uarts fifo, which ends
in problems, when you send long commands to u-boots
commandline.
Detected this issue with automated tbot tests on am335x
based shc board.
The error does not popup, if you type commands. You need
to copy&paste a long command to u-boots commandshell
(or send a long command with tbot)
Possible boards/plattforms with problems:
./arch/arm/cpu/arm926ejs/lpc32xx/devices.c
./arch/arm/mach-tegra/board.c
./board/overo/overo.c
./board/quipos/cairo/cairo.c
./board/logicpd/omap3som/omap3logic.c
./board/logicpd/zoom1/zoom1.c
./board/timll/devkit8000/devkit8000.c
./board/lg/sniper/sniper.c
./board/ti/beagle/beagle.c
./drivers/serial/serial_rockchip.c
Signed-off-by: Heiko Schocher <hs@denx.de>
Signed-off-by: Ladislav Michl <ladis@linux-mips.org>
Tested-by: Adam Ford <aford173@gmail.com>
Reviewed-by: Tom Rini <trini@konsulko.com>
45 lines
1.1 KiB
C
45 lines
1.1 KiB
C
/*
|
|
* Copyright (c) 2015 Google, Inc
|
|
*
|
|
* SPDX-License-Identifier: GPL-2.0+
|
|
*/
|
|
|
|
#include <common.h>
|
|
#include <debug_uart.h>
|
|
#include <dm.h>
|
|
#include <dt-structs.h>
|
|
#include <ns16550.h>
|
|
#include <serial.h>
|
|
#include <asm/arch/clock.h>
|
|
|
|
struct rockchip_uart_platdata {
|
|
struct dtd_rockchip_rk3288_uart dtplat;
|
|
struct ns16550_platdata plat;
|
|
};
|
|
|
|
struct dtd_rockchip_rk3288_uart *dtplat, s_dtplat;
|
|
|
|
static int rockchip_serial_probe(struct udevice *dev)
|
|
{
|
|
struct rockchip_uart_platdata *plat = dev_get_platdata(dev);
|
|
|
|
/* Create some new platform data for the standard driver */
|
|
plat->plat.base = plat->dtplat.reg[0];
|
|
plat->plat.reg_shift = plat->dtplat.reg_shift;
|
|
plat->plat.clock = plat->dtplat.clock_frequency;
|
|
plat->plat.fcr = UART_FCR_DEFVAL;
|
|
dev->platdata = &plat->plat;
|
|
|
|
return ns16550_serial_probe(dev);
|
|
}
|
|
|
|
U_BOOT_DRIVER(rockchip_rk3288_uart) = {
|
|
.name = "rockchip_rk3288_uart",
|
|
.id = UCLASS_SERIAL,
|
|
.priv_auto_alloc_size = sizeof(struct NS16550),
|
|
.platdata_auto_alloc_size = sizeof(struct rockchip_uart_platdata),
|
|
.probe = rockchip_serial_probe,
|
|
.ops = &ns16550_serial_ops,
|
|
.flags = DM_FLAG_PRE_RELOC,
|
|
};
|