mirror of
https://github.com/brain-hackers/u-boot-brain
synced 2024-08-18 16:08:53 +09:00
![Alexander Graf](/assets/img/avatar_default.png)
The board_r init function was complaining that we are looping through an array, calling all our tiny init stubs sequentially via indirect function calls (which can't be speculated, so they are slow). The solution to that is pretty easy though. All we need to do is inline the function that loops through the functions and the compiler will automatically convert almost all indirect calls into direct inlined code. With this patch, the overall code size drops (by 40 bytes on riscv64) and boot time should become measurably faster for every target. Signed-off-by: Alexander Graf <agraf@suse.de>
47 lines
1001 B
C
47 lines
1001 B
C
/* SPDX-License-Identifier: GPL-2.0+ */
|
|
/*
|
|
* Copyright (c) 2011 The Chromium OS Authors.
|
|
*/
|
|
|
|
#ifndef __INITCALL_H
|
|
#define __INITCALL_H
|
|
|
|
typedef int (*init_fnc_t)(void);
|
|
|
|
#include <common.h>
|
|
#include <initcall.h>
|
|
#include <efi.h>
|
|
|
|
DECLARE_GLOBAL_DATA_PTR;
|
|
|
|
static inline int initcall_run_list(const init_fnc_t init_sequence[])
|
|
{
|
|
const init_fnc_t *init_fnc_ptr;
|
|
|
|
for (init_fnc_ptr = init_sequence; *init_fnc_ptr; ++init_fnc_ptr) {
|
|
unsigned long reloc_ofs = 0;
|
|
int ret;
|
|
|
|
if (gd->flags & GD_FLG_RELOC)
|
|
reloc_ofs = gd->reloc_off;
|
|
#ifdef CONFIG_EFI_APP
|
|
reloc_ofs = (unsigned long)image_base;
|
|
#endif
|
|
debug("initcall: %p", (char *)*init_fnc_ptr - reloc_ofs);
|
|
if (gd->flags & GD_FLG_RELOC)
|
|
debug(" (relocated to %p)\n", (char *)*init_fnc_ptr);
|
|
else
|
|
debug("\n");
|
|
ret = (*init_fnc_ptr)();
|
|
if (ret) {
|
|
printf("initcall sequence %p failed at call %p (err=%d)\n",
|
|
init_sequence,
|
|
(char *)*init_fnc_ptr - reloc_ofs, ret);
|
|
return -1;
|
|
}
|
|
}
|
|
return 0;
|
|
}
|
|
|
|
#endif
|