mirror of
https://github.com/brain-hackers/u-boot-brain
synced 2024-07-23 19:39:44 +09:00
b75d8dc564
The Linux coding style guide (Documentation/process/coding-style.rst) clearly says: It's a **mistake** to use typedef for structures and pointers. Besides, using typedef for structures is annoying when you try to make headers self-contained. Let's say you have the following function declaration in a header: void foo(bd_t *bd); This is not self-contained since bd_t is not defined. To tell the compiler what 'bd_t' is, you need to include <asm/u-boot.h> #include <asm/u-boot.h> void foo(bd_t *bd); Then, the include direcective pulls in more bloat needlessly. If you use 'struct bd_info' instead, it is enough to put a forward declaration as follows: struct bd_info; void foo(struct bd_info *bd); Right, typedef'ing bd_t is a mistake. I used coccinelle to generate this commit. The semantic patch that makes this change is as follows: <smpl> @@ typedef bd_t; @@ -bd_t +struct bd_info </smpl> Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
35 lines
882 B
C
35 lines
882 B
C
// SPDX-License-Identifier: GPL-2.0+
|
|
/*
|
|
* PPC-specific information for the 'bd' command
|
|
*
|
|
* (C) Copyright 2003
|
|
* Wolfgang Denk, DENX Software Engineering, wd@denx.de.
|
|
*/
|
|
|
|
#include <common.h>
|
|
#include <init.h>
|
|
|
|
DECLARE_GLOBAL_DATA_PTR;
|
|
|
|
void arch_print_bdinfo(void)
|
|
{
|
|
struct bd_info *bd = gd->bd;
|
|
|
|
#if defined(CONFIG_SYS_INIT_RAM_ADDR)
|
|
bdinfo_print_num("sramstart", (ulong)bd->bi_sramstart);
|
|
bdinfo_print_num("sramsize", (ulong)bd->bi_sramsize);
|
|
#endif
|
|
bdinfo_print_mhz("busfreq", bd->bi_busfreq);
|
|
#if defined(CONFIG_SYS_MBAR)
|
|
bdinfo_print_num("mbar", bd->bi_mbar_base);
|
|
#endif
|
|
bdinfo_print_mhz("cpufreq", bd->bi_intfreq);
|
|
if (IS_ENABLED(CONFIG_PCI))
|
|
bdinfo_print_mhz("pcifreq", bd->bi_pcifreq);
|
|
#ifdef CONFIG_EXTRA_CLOCK
|
|
bdinfo_print_mhz("flbfreq", bd->bi_flbfreq);
|
|
bdinfo_print_mhz("inpfreq", bd->bi_inpfreq);
|
|
bdinfo_print_mhz("vcofreq", bd->bi_vcofreq);
|
|
#endif
|
|
}
|