mirror of
https://github.com/brain-hackers/u-boot-brain
synced 2024-06-09 23:36:03 +09:00
b75d8dc564
The Linux coding style guide (Documentation/process/coding-style.rst) clearly says: It's a **mistake** to use typedef for structures and pointers. Besides, using typedef for structures is annoying when you try to make headers self-contained. Let's say you have the following function declaration in a header: void foo(bd_t *bd); This is not self-contained since bd_t is not defined. To tell the compiler what 'bd_t' is, you need to include <asm/u-boot.h> #include <asm/u-boot.h> void foo(bd_t *bd); Then, the include direcective pulls in more bloat needlessly. If you use 'struct bd_info' instead, it is enough to put a forward declaration as follows: struct bd_info; void foo(struct bd_info *bd); Right, typedef'ing bd_t is a mistake. I used coccinelle to generate this commit. The semantic patch that makes this change is as follows: <smpl> @@ typedef bd_t; @@ -bd_t +struct bd_info </smpl> Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
126 lines
3.0 KiB
C
126 lines
3.0 KiB
C
// SPDX-License-Identifier: GPL-2.0+
|
|
/*
|
|
* Copyright 2009-2011 Freescale Semiconductor, Inc.
|
|
* Andy Fleming <afleming@gmail.com>
|
|
* Some part is taken from tsec.c
|
|
*/
|
|
#include <common.h>
|
|
#include <miiphy.h>
|
|
#include <phy.h>
|
|
#include <asm/io.h>
|
|
#include <fsl_tgec.h>
|
|
#include <fm_eth.h>
|
|
|
|
/*
|
|
* Write value to the PHY for this device to the register at regnum, waiting
|
|
* until the write is done before it returns. All PHY configuration has to be
|
|
* done through the TSEC1 MIIM regs
|
|
*/
|
|
static int tgec_mdio_write(struct mii_dev *bus, int port_addr, int dev_addr,
|
|
int regnum, u16 value)
|
|
{
|
|
u32 mdio_ctl;
|
|
u32 stat_val;
|
|
struct tgec_mdio_controller *regs = bus->priv;
|
|
|
|
if (dev_addr == MDIO_DEVAD_NONE)
|
|
return 0;
|
|
|
|
/* Wait till the bus is free */
|
|
stat_val = MDIO_STAT_CLKDIV(100);
|
|
out_be32(®s->mdio_stat, stat_val);
|
|
while ((in_be32(®s->mdio_stat)) & MDIO_STAT_BSY)
|
|
;
|
|
|
|
/* Set the port and dev addr */
|
|
mdio_ctl = MDIO_CTL_PORT_ADDR(port_addr) | MDIO_CTL_DEV_ADDR(dev_addr);
|
|
out_be32(®s->mdio_ctl, mdio_ctl);
|
|
|
|
/* Set the register address */
|
|
out_be32(®s->mdio_addr, regnum & 0xffff);
|
|
|
|
/* Wait till the bus is free */
|
|
while ((in_be32(®s->mdio_stat)) & MDIO_STAT_BSY)
|
|
;
|
|
|
|
/* Write the value to the register */
|
|
out_be32(®s->mdio_data, MDIO_DATA(value));
|
|
|
|
/* Wait till the MDIO write is complete */
|
|
while ((in_be32(®s->mdio_data)) & MDIO_DATA_BSY)
|
|
;
|
|
|
|
return 0;
|
|
}
|
|
|
|
/*
|
|
* Reads from register regnum in the PHY for device dev, returning the value.
|
|
* Clears miimcom first. All PHY configuration has to be done through the
|
|
* TSEC1 MIIM regs
|
|
*/
|
|
static int tgec_mdio_read(struct mii_dev *bus, int port_addr, int dev_addr,
|
|
int regnum)
|
|
{
|
|
u32 mdio_ctl;
|
|
u32 stat_val;
|
|
struct tgec_mdio_controller *regs = bus->priv;
|
|
|
|
if (dev_addr == MDIO_DEVAD_NONE)
|
|
return 0xffff;
|
|
|
|
stat_val = MDIO_STAT_CLKDIV(100);
|
|
out_be32(®s->mdio_stat, stat_val);
|
|
/* Wait till the bus is free */
|
|
while ((in_be32(®s->mdio_stat)) & MDIO_STAT_BSY)
|
|
;
|
|
|
|
/* Set the Port and Device Addrs */
|
|
mdio_ctl = MDIO_CTL_PORT_ADDR(port_addr) | MDIO_CTL_DEV_ADDR(dev_addr);
|
|
out_be32(®s->mdio_ctl, mdio_ctl);
|
|
|
|
/* Set the register address */
|
|
out_be32(®s->mdio_addr, regnum & 0xffff);
|
|
|
|
/* Wait till the bus is free */
|
|
while ((in_be32(®s->mdio_stat)) & MDIO_STAT_BSY)
|
|
;
|
|
|
|
/* Initiate the read */
|
|
mdio_ctl |= MDIO_CTL_READ;
|
|
out_be32(®s->mdio_ctl, mdio_ctl);
|
|
|
|
/* Wait till the MDIO write is complete */
|
|
while ((in_be32(®s->mdio_data)) & MDIO_DATA_BSY)
|
|
;
|
|
|
|
/* Return all Fs if nothing was there */
|
|
if (in_be32(®s->mdio_stat) & MDIO_STAT_RD_ER)
|
|
return 0xffff;
|
|
|
|
return in_be32(®s->mdio_data) & 0xffff;
|
|
}
|
|
|
|
static int tgec_mdio_reset(struct mii_dev *bus)
|
|
{
|
|
return 0;
|
|
}
|
|
|
|
int fm_tgec_mdio_init(struct bd_info *bis, struct tgec_mdio_info *info)
|
|
{
|
|
struct mii_dev *bus = mdio_alloc();
|
|
|
|
if (!bus) {
|
|
printf("Failed to allocate FM TGEC MDIO bus\n");
|
|
return -1;
|
|
}
|
|
|
|
bus->read = tgec_mdio_read;
|
|
bus->write = tgec_mdio_write;
|
|
bus->reset = tgec_mdio_reset;
|
|
strcpy(bus->name, info->name);
|
|
|
|
bus->priv = info->regs;
|
|
|
|
return mdio_register(bus);
|
|
}
|