mirror of
https://github.com/brain-hackers/u-boot-brain
synced 2024-06-09 23:36:03 +09:00
b75d8dc564
The Linux coding style guide (Documentation/process/coding-style.rst) clearly says: It's a **mistake** to use typedef for structures and pointers. Besides, using typedef for structures is annoying when you try to make headers self-contained. Let's say you have the following function declaration in a header: void foo(bd_t *bd); This is not self-contained since bd_t is not defined. To tell the compiler what 'bd_t' is, you need to include <asm/u-boot.h> #include <asm/u-boot.h> void foo(bd_t *bd); Then, the include direcective pulls in more bloat needlessly. If you use 'struct bd_info' instead, it is enough to put a forward declaration as follows: struct bd_info; void foo(struct bd_info *bd); Right, typedef'ing bd_t is a mistake. I used coccinelle to generate this commit. The semantic patch that makes this change is as follows: <smpl> @@ typedef bd_t; @@ -bd_t +struct bd_info </smpl> Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
110 lines
2.6 KiB
C
110 lines
2.6 KiB
C
// SPDX-License-Identifier: GPL-2.0+
|
|
/*
|
|
* Implements the 'bd' command to show board information
|
|
*
|
|
* (C) Copyright 2003
|
|
* Wolfgang Denk, DENX Software Engineering, wd@denx.de.
|
|
*/
|
|
|
|
#include <common.h>
|
|
#include <command.h>
|
|
#include <env.h>
|
|
#include <net.h>
|
|
#include <vsprintf.h>
|
|
#include <asm/cache.h>
|
|
|
|
DECLARE_GLOBAL_DATA_PTR;
|
|
|
|
void bdinfo_print_num(const char *name, ulong value)
|
|
{
|
|
printf("%-12s= 0x%0*lx\n", name, 2 * (int)sizeof(value), value);
|
|
}
|
|
|
|
static void print_eth(int idx)
|
|
{
|
|
char name[10], *val;
|
|
if (idx)
|
|
sprintf(name, "eth%iaddr", idx);
|
|
else
|
|
strcpy(name, "ethaddr");
|
|
val = env_get(name);
|
|
if (!val)
|
|
val = "(not set)";
|
|
printf("%-12s= %s\n", name, val);
|
|
}
|
|
|
|
static void print_lnum(const char *name, unsigned long long value)
|
|
{
|
|
printf("%-12s= 0x%.8llX\n", name, value);
|
|
}
|
|
|
|
void bdinfo_print_mhz(const char *name, unsigned long hz)
|
|
{
|
|
char buf[32];
|
|
|
|
printf("%-12s= %6s MHz\n", name, strmhz(buf, hz));
|
|
}
|
|
|
|
static void print_bi_dram(const struct bd_info *bd)
|
|
{
|
|
#ifdef CONFIG_NR_DRAM_BANKS
|
|
int i;
|
|
|
|
for (i = 0; i < CONFIG_NR_DRAM_BANKS; ++i) {
|
|
if (bd->bi_dram[i].size) {
|
|
bdinfo_print_num("DRAM bank", i);
|
|
bdinfo_print_num("-> start", bd->bi_dram[i].start);
|
|
bdinfo_print_num("-> size", bd->bi_dram[i].size);
|
|
}
|
|
}
|
|
#endif
|
|
}
|
|
|
|
__weak void arch_print_bdinfo(void)
|
|
{
|
|
}
|
|
|
|
int do_bdinfo(struct cmd_tbl *cmdtp, int flag, int argc, char *const argv[])
|
|
{
|
|
struct bd_info *bd = gd->bd;
|
|
|
|
#ifdef DEBUG
|
|
bdinfo_print_num("bd address", (ulong)bd);
|
|
#endif
|
|
bdinfo_print_num("boot_params", (ulong)bd->bi_boot_params);
|
|
print_bi_dram(bd);
|
|
bdinfo_print_num("memstart", (ulong)bd->bi_memstart);
|
|
print_lnum("memsize", (u64)bd->bi_memsize);
|
|
bdinfo_print_num("flashstart", (ulong)bd->bi_flashstart);
|
|
bdinfo_print_num("flashsize", (ulong)bd->bi_flashsize);
|
|
bdinfo_print_num("flashoffset", (ulong)bd->bi_flashoffset);
|
|
printf("baudrate = %u bps\n", gd->baudrate);
|
|
bdinfo_print_num("relocaddr", gd->relocaddr);
|
|
bdinfo_print_num("reloc off", gd->reloc_off);
|
|
printf("%-12s= %u-bit\n", "Build", (uint)sizeof(void *) * 8);
|
|
if (IS_ENABLED(CONFIG_CMD_NET)) {
|
|
printf("current eth = %s\n", eth_get_name());
|
|
print_eth(0);
|
|
printf("IP addr = %s\n", env_get("ipaddr"));
|
|
}
|
|
bdinfo_print_num("fdt_blob", (ulong)gd->fdt_blob);
|
|
bdinfo_print_num("new_fdt", (ulong)gd->new_fdt);
|
|
bdinfo_print_num("fdt_size", (ulong)gd->fdt_size);
|
|
#if defined(CONFIG_LCD) || defined(CONFIG_VIDEO) || defined(CONFIG_DM_VIDEO)
|
|
bdinfo_print_num("FB base ", gd->fb_base);
|
|
#endif
|
|
#if CONFIG_IS_ENABLED(MULTI_DTB_FIT)
|
|
bdinfo_print_num("multi_dtb_fit", (ulong)gd->multi_dtb_fit);
|
|
#endif
|
|
|
|
arch_print_bdinfo();
|
|
|
|
return 0;
|
|
}
|
|
|
|
U_BOOT_CMD(
|
|
bdinfo, 1, 1, do_bdinfo,
|
|
"print Board Info structure",
|
|
""
|
|
);
|