brain-hackers_pepepper-mirror/u-boot-brain
1
0
Fork 0
mirror of https://github.com/brain-hackers/u-boot-brain synced 2024-09-23 05:00:24 +09:00
Code Issues Projects Releases Wiki Activity

test: dm_mdio: avoid out of bounds access

Browse Source 
SANDBOX_PHY_REG_CNT is not an allowable index for the array
u16 reg[SANDBOX_PHY_REG_CNT].

Identified by cppcheck.

Fixes: b47edf8069 ("test: dm_mdio: add a 2nd register to the emulated PHY")
Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
Acked-by: Joe Hershberger <joe.hershberger@ni.com>
This commit is contained in:
Heinrich Schuchardt 2019-07-30 23:49:00 +02:00 committed by Joe Hershberger
parent a37c082248
commit fd6d88f55b
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/net/mdio_sandbox.c
View File

@ -27,7 +27,7 @@ static int mdio_sandbox_read(struct udevice *dev, int addr, int devad, int reg)
return -ENODEV; return -ENODEV;
if (devad != MDIO_DEVAD_NONE) if (devad != MDIO_DEVAD_NONE)
return -ENODEV; return -ENODEV;
if (reg < 0 || reg > SANDBOX_PHY_REG_CNT) if (reg < 0 || reg >= SANDBOX_PHY_REG_CNT)
return -ENODEV; return -ENODEV;
return priv->reg[reg]; return priv->reg[reg];
@ -45,7 +45,7 @@ static int mdio_sandbox_write(struct udevice *dev, int addr, int devad, int reg,
return -ENODEV; return -ENODEV;
if (devad != MDIO_DEVAD_NONE) if (devad != MDIO_DEVAD_NONE)
return -ENODEV; return -ENODEV;
if (reg < 0 || reg > SANDBOX_PHY_REG_CNT) if (reg < 0 || reg >= SANDBOX_PHY_REG_CNT)
return -ENODEV; return -ENODEV;
priv->reg[reg] = val; priv->reg[reg] = val;