brain-hackers_pepepper-mirror/u-boot-brain
1
0
Fork 0
mirror of https://github.com/brain-hackers/u-boot-brain synced 2024-09-28 07:30:26 +09:00
Code Issues Projects Releases Wiki Activity

dm: device: fail uclass_find_first_device() if list_empty

Browse Source 
While uclass_find_device() fails with -ENODEV in case of list_empty
strangely uclass_find_first_device() returns 0.

Fix uclass_find_first_device() to also fail with -ENODEV instead.

Signed-off-by: Marcel Ziswiler <marcel.ziswiler@toradex.com>
Reviewed-by: Simon Glass <sjg@chromium.org>
This commit is contained in:
Marcel Ziswiler 2019-02-01 16:01:07 +01:00 committed by Tom Rini
parent a765adc08f
commit f388564965
2 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
drivers/core/uclass.c
View File

@ -225,7 +225,7 @@ int uclass_find_first_device(enum uclass_id id, struct udevice **devp)
if (ret)
return ret;
if (list_empty(&uc->dev_head))
return 0;
return -ENODEV;
*devp = list_first_entry(&uc->dev_head, struct udevice, uclass_node);

4
test/dm/core.c
View File

@ -749,6 +749,10 @@ static int dm_test_uclass_devices_find(struct unit_test_state *uts)
ut_assert(dev);
}
ret = uclass_find_first_device(UCLASS_TEST_DUMMY, &dev);
ut_assert(ret == -ENODEV);
ut_assert(!dev);
return 0;
}
DM_TEST(dm_test_uclass_devices_find, DM_TESTF_SCAN_PDATA);