From fa9da8ee60a7387b9e9b0358bd73ef5dbc73736c Mon Sep 17 00:00:00 2001 From: Heinrich Schuchardt Date: Sun, 18 Mar 2018 13:05:58 +0100 Subject: [PATCH 1/2] usb: gadget: remove duplicate assignment. We should not make the same assignement twice. Signed-off-by: Heinrich Schuchardt --- drivers/usb/gadget/composite.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/gadget/composite.c b/drivers/usb/gadget/composite.c index a87639def9..6e4426cced 100644 --- a/drivers/usb/gadget/composite.c +++ b/drivers/usb/gadget/composite.c @@ -165,7 +165,7 @@ static int config_buf(struct usb_configuration *config, int len = USB_BUFSIZ - USB_DT_CONFIG_SIZE; void *next = buf + USB_DT_CONFIG_SIZE; struct usb_descriptor_header **descriptors; - struct usb_config_descriptor *c = buf; + struct usb_config_descriptor *c; int status; struct usb_function *f; From 48cdfa2f8177dbdfc77c365c0f3f918ceadbe484 Mon Sep 17 00:00:00 2001 From: Heinrich Schuchardt Date: Sun, 18 Mar 2018 13:12:14 +0100 Subject: [PATCH 2/2] usb: f_mass_storage: simplify logical expression An unsigned int is always >= 0. Signed-off-by: Heinrich Schuchardt --- drivers/usb/gadget/f_mass_storage.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/gadget/f_mass_storage.c b/drivers/usb/gadget/f_mass_storage.c index 1ecb92ac6b..7d7ed4242b 100644 --- a/drivers/usb/gadget/f_mass_storage.c +++ b/drivers/usb/gadget/f_mass_storage.c @@ -1744,7 +1744,7 @@ static int check_command(struct fsg_common *common, int cmnd_size, common->lun, lun); /* Check the LUN */ - if (common->lun >= 0 && common->lun < common->nluns) { + if (common->lun < common->nluns) { curlun = &common->luns[common->lun]; if (common->cmnd[0] != SC_REQUEST_SENSE) { curlun->sense_data = SS_NO_SENSE;