From d8a395109e127cda11bcfceae2f7200c785e8443 Mon Sep 17 00:00:00 2001 From: Alexandru Gagniuc Date: Mon, 29 Mar 2021 12:05:13 -0500 Subject: [PATCH] spl: fit: Warn if FIT contains "fpga" property in config node Commit 4afc4f37c70e ("doc: FIT image: Clarify format and simplify syntax") requires that FPGA images be referenced through the "loadables" in the config node. This means that "fpga" properties in config nodes are deprecated. Given that there are likely FIT images which use "fpga", let's not break those right away. Print a warning message that such use is deprecated, and give users a couple of releases to update their Signed-off-by: Alexandru Gagniuc --- common/spl/spl_fit.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/common/spl/spl_fit.c b/common/spl/spl_fit.c index 514ec9138f..496fabc4e7 100644 --- a/common/spl/spl_fit.c +++ b/common/spl/spl_fit.c @@ -529,6 +529,12 @@ __weak bool spl_load_simple_fit_skip_processing(void) return false; } +static void warn_deprecated(const char *msg) +{ + printf("DEPRECATED: %s\n", msg); + printf("\tSee doc/uImage.FIT/source_file_format.txt\n"); +} + static int spl_fit_upload_fpga(struct spl_fit_info *ctx, int node, struct spl_image_info *fpga_image) { @@ -562,6 +568,8 @@ static int spl_fit_load_fpga(struct spl_fit_info *ctx, if (node < 0) return node; + warn_deprecated("'fpga' property in config node. Use 'loadables'"); + /* Load the image and set up the fpga_image structure */ ret = spl_load_fit_image(info, sector, ctx, node, &fpga_image); if (ret) {