From 31d4045d4be8263828689c7eb6ff4e72071ad5ce Mon Sep 17 00:00:00 2001 From: Andrejs Cainikovs Date: Fri, 1 Mar 2019 13:27:59 +0000 Subject: [PATCH 1/2] net: dm: fec: Support phy-reset-post-delay property As per Linux kernel DT binding doc: - phy-reset-post-delay : Post reset delay in milliseconds. If present then a delay of phy-reset-post-delay milliseconds will be observed after the phy-reset-gpios has been toggled. Can be omitted thus no delay is observed. Delay is in range of 1ms to 1000ms. Other delays are invalid. Signed-off-by: Andrejs Cainikovs Reviewed-by: Anatolij Gustschin Reviewed-by: Stefano Babic Acked-by: Joe Hershberger Acked-by: Lukasz Majewski --- drivers/net/fec_mxc.c | 11 +++++++++++ drivers/net/fec_mxc.h | 1 + 2 files changed, 12 insertions(+) diff --git a/drivers/net/fec_mxc.c b/drivers/net/fec_mxc.c index f991b40b38..84f010d805 100644 --- a/drivers/net/fec_mxc.c +++ b/drivers/net/fec_mxc.c @@ -1309,6 +1309,8 @@ static void fec_gpio_reset(struct fec_priv *priv) dm_gpio_set_value(&priv->phy_reset_gpio, 1); mdelay(priv->reset_delay); dm_gpio_set_value(&priv->phy_reset_gpio, 0); + if (priv->reset_post_delay) + mdelay(priv->reset_post_delay); } } #endif @@ -1468,6 +1470,15 @@ static int fecmxc_ofdata_to_platdata(struct udevice *dev) /* property value wrong, use default value */ priv->reset_delay = 1; } + + priv->reset_post_delay = dev_read_u32_default(dev, + "phy-reset-post-delay", + 0); + if (priv->reset_post_delay > 1000) { + printf("FEC MXC: phy reset post delay should be <= 1000ms\n"); + /* property value wrong, use default value */ + priv->reset_post_delay = 0; + } #endif return 0; diff --git a/drivers/net/fec_mxc.h b/drivers/net/fec_mxc.h index e9a661f0a1..e5f2dd75c5 100644 --- a/drivers/net/fec_mxc.h +++ b/drivers/net/fec_mxc.h @@ -258,6 +258,7 @@ struct fec_priv { #ifdef CONFIG_DM_GPIO struct gpio_desc phy_reset_gpio; uint32_t reset_delay; + uint32_t reset_post_delay; #endif #ifdef CONFIG_DM_ETH u32 interface; From e82fa10b3ef745ea08d5dac8ff088553846c2ca1 Mon Sep 17 00:00:00 2001 From: Andrejs Cainikovs Date: Fri, 1 Mar 2019 13:28:00 +0000 Subject: [PATCH 2/2] dts: imx8qxp-mek: Add PHY post reset delay PHY cannot be detected unless we wait about 150 ms. Signed-off-by: Andrejs Cainikovs Reviewed-by: Anatolij Gustschin Reviewed-by: Stefano Babic Acked-by: Joe Hershberger --- arch/arm/dts/fsl-imx8qxp-mek.dts | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/dts/fsl-imx8qxp-mek.dts b/arch/arm/dts/fsl-imx8qxp-mek.dts index 41f7ec1763..4f35fbe31d 100644 --- a/arch/arm/dts/fsl-imx8qxp-mek.dts +++ b/arch/arm/dts/fsl-imx8qxp-mek.dts @@ -224,6 +224,7 @@ status = "okay"; phy-reset-gpios = <&pca9557_a 4 GPIO_ACTIVE_LOW>; phy-reset-duration = <10>; + phy-reset-post-delay = <150>; mdio { #address-cells = <1>;