mirror of
https://github.com/brain-hackers/u-boot-brain
synced 2024-10-01 09:00:45 +09:00
net: zynq_gem: Do not return -ENOSYS on success
The .read_rom_hwaddr net_ops hook does not check the return value, which is why it was never caught that we are currently returning 0 if the read_rom_hwaddr function return -ENOSYS and -ENOSYS otherwise. In this case we can simplify this by just returning the result of the function. Signed-off-by: Olliver Schinagl <oliver@schinagl.nl> Acked-by: Joe Hershberger <joe.hershberger@ni.com> Acked-by: Michal Simek <michal.simek@xilinx.com>
This commit is contained in:
parent
6ec922fae2
commit
b233089787
@ -587,14 +587,12 @@ __weak int zynq_board_read_rom_ethaddr(unsigned char *ethaddr)
|
|||||||
|
|
||||||
static int zynq_gem_read_rom_mac(struct udevice *dev)
|
static int zynq_gem_read_rom_mac(struct udevice *dev)
|
||||||
{
|
{
|
||||||
int retval;
|
|
||||||
struct eth_pdata *pdata = dev_get_platdata(dev);
|
struct eth_pdata *pdata = dev_get_platdata(dev);
|
||||||
|
|
||||||
retval = zynq_board_read_rom_ethaddr(pdata->enetaddr);
|
if (!pdata)
|
||||||
if (retval == -ENOSYS)
|
return -ENOSYS;
|
||||||
retval = 0;
|
|
||||||
|
|
||||||
return retval;
|
return zynq_board_read_rom_ethaddr(pdata->enetaddr);
|
||||||
}
|
}
|
||||||
|
|
||||||
static int zynq_gem_miiphy_read(struct mii_dev *bus, int addr,
|
static int zynq_gem_miiphy_read(struct mii_dev *bus, int addr,
|
||||||
|
Loading…
Reference in New Issue
Block a user