From 7d075055acf4a1d095234fd0f7efa16a817f2d36 Mon Sep 17 00:00:00 2001 From: Krzysztof Kozlowski Date: Sat, 11 May 2019 13:24:31 +0200 Subject: [PATCH 1/3] arm: exynos: arndale: Remove unused CONFIG_POWER and CONFIG_POWER_I2C The CONFIG_POWER and CONFIG_POWER_I2C were introduced in include/configs/exynos5-common.h in commit 19bd3aaa5991 ("exynos5: fix build break by adding CONFIG_POWER") and then it propagated up to include/configs/arndale.h. However before that commit, there was no build break at all on Arndale and SMDK5250 boards. It seems the commit fixed nothing and just added unused defines. In fact, the Arndale board is not configuring its PMIC (S5M8767) which uses I2C bus. Signed-off-by: Krzysztof Kozlowski Reviewed-by: Simon Glass Signed-off-by: Minkyu Kang --- include/configs/arndale.h | 8 -------- 1 file changed, 8 deletions(-) diff --git a/include/configs/arndale.h b/include/configs/arndale.h index dd321c4748..841f361648 100644 --- a/include/configs/arndale.h +++ b/include/configs/arndale.h @@ -29,10 +29,6 @@ #define CONFIG_SYS_INIT_SP_ADDR CONFIG_IRAM_STACK -/* PMIC */ -#define CONFIG_POWER -#define CONFIG_POWER_I2C - #define CONFIG_PREBOOT #define CONFIG_S5P_PA_SYSRAM 0x02020000 @@ -41,8 +37,4 @@ /* The PERIPHBASE in the CBAR register is wrong on the Arndale, so override it */ #define CONFIG_ARM_GIC_BASE_ADDRESS 0x10480000 -/* Power */ -#define CONFIG_POWER -#define CONFIG_POWER_I2C - #endif /* __CONFIG_H */ From bc85f7c87af1aafac7032db85c815ab3927304bf Mon Sep 17 00:00:00 2001 From: Krzysztof Kozlowski Date: Sat, 11 May 2019 13:24:32 +0200 Subject: [PATCH 2/3] arm: exynos: arndale: Remove unused CONFIG_DM_I2C_COMPAT The CONFIG_DM_I2C_COMPAT was introduced in include/configs/exynos5-common.h in commit 189d80166b31 ("exynos5: enable dm i2c") and then it propagated up to configs/arndale_defconfig. However since beginning the Arndale board (Exynos5250) was not using I2C. In fact, the Arndale board is not configuring its PMIC (S5M8767) which uses I2C bus. This setting can be thus safely removed to fix build warning: This board uses CONFIG_DM_I2C_COMPAT. Please remove (possibly in a subsequent patch in your series) before sending patches to the mailing list. Signed-off-by: Krzysztof Kozlowski Reviewed-by: Simon Glass Signed-off-by: Minkyu Kang --- configs/arndale_defconfig | 1 - 1 file changed, 1 deletion(-) diff --git a/configs/arndale_defconfig b/configs/arndale_defconfig index 9727d28c12..e90d670f68 100644 --- a/configs/arndale_defconfig +++ b/configs/arndale_defconfig @@ -25,7 +25,6 @@ CONFIG_CMD_SOUND=y CONFIG_CMD_EXT4_WRITE=y CONFIG_DEFAULT_DEVICE_TREE="exynos5250-arndale" CONFIG_ENV_IS_IN_MMC=y -CONFIG_DM_I2C_COMPAT=y CONFIG_SUPPORT_EMMC_BOOT=y CONFIG_MMC_DW=y CONFIG_MMC_SDHCI=y From f4b2ab97ed37ea6b202aaa951d31dab9187e3720 Mon Sep 17 00:00:00 2001 From: Krzysztof Kozlowski Date: Sat, 11 May 2019 13:24:33 +0200 Subject: [PATCH 3/3] configs: arndale: Use appropriate driver for Asix AX88760 Arndale board has an Asix AX88760 USB 2.0 Hub and Fast Ethernet combo. The appropriate driver for it is USB_ETHER_ASIX. The mistake probably came from misinterpretation of commit e9954b867ce0 ("usb: eth: add ASIX AX88179 DRIVER") which was tested on RECS5250 COM module. This module indeed has Exynos5250 and some similarities with Arndale 5250 board but the USB/Ethernet chip used there is apparently different. Fixes: f58ad98a621c ("usb: net: migrate USB Ethernet adapters to Kconfig") Signed-off-by: Krzysztof Kozlowski Reviewed-by: Lukasz Majewski Signed-off-by: Minkyu Kang --- configs/arndale_defconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configs/arndale_defconfig b/configs/arndale_defconfig index e90d670f68..37ad6accc3 100644 --- a/configs/arndale_defconfig +++ b/configs/arndale_defconfig @@ -42,4 +42,4 @@ CONFIG_USB_XHCI_HCD=y CONFIG_USB_XHCI_DWC3=y CONFIG_USB_EHCI_HCD=y CONFIG_USB_HOST_ETHER=y -CONFIG_USB_ETHER_ASIX88179=y +CONFIG_USB_ETHER_ASIX=y