tee: optee: Change printing during optee_probe

Right now the error messages when optee has a version mismatch or shared
memory is not configured are done with a debug().
That's not very convenient since you have to enable debugging to figure
out what's going on, although this is an actual error.

So let's switch the debug() -> dev_err() and report those explicitly.

Signed-off-by: Ilias Apalodimas <ilias.apalodimas@linaro.org>
Reviewed-by: Patrick Delaunay <patrick.delaunay@foss.st.com>
This commit is contained in:
Ilias Apalodimas 2021-03-10 15:35:11 +02:00 committed by Tom Rini
parent ac3821430e
commit 92e8489611
1 changed files with 3 additions and 3 deletions

View File

@ -624,14 +624,14 @@ static int optee_probe(struct udevice *dev)
u32 sec_caps;
if (!is_optee_api(pdata->invoke_fn)) {
debug("%s: OP-TEE api uid mismatch\n", __func__);
dev_err(dev, "OP-TEE api uid mismatch\n");
return -ENOENT;
}
print_os_revision(dev, pdata->invoke_fn);
if (!api_revision_is_compatible(pdata->invoke_fn)) {
debug("%s: OP-TEE api revision mismatch\n", __func__);
dev_err(dev, "OP-TEE api revision mismatch\n");
return -ENOENT;
}
@ -642,7 +642,7 @@ static int optee_probe(struct udevice *dev)
*/
if (!exchange_capabilities(pdata->invoke_fn, &sec_caps) ||
!(sec_caps & OPTEE_SMC_SEC_CAP_DYNAMIC_SHM)) {
debug("%s: OP-TEE capabilities mismatch\n", __func__);
dev_err(dev, "OP-TEE capabilities mismatch\n");
return -ENOENT;
}