brain-hackers_pepepper-mirror/u-boot-brain
1
0
Fork 0
mirror of https://github.com/brain-hackers/u-boot-brain synced 2024-09-30 08:30:50 +09:00
Code Issues Projects Releases Wiki Activity

mkimage: Fix missing free() and close() in fit_build()

Browse Source 
Make sure that both the error path and normal return free the buffer and
close the file.

Reported-by: Coverity (CID: 138491)
Signed-off-by: Simon Glass <sjg@chromium.org>
Reviewed-by: Tom Rini <trini@konsulko.com>
This commit is contained in:
Simon Glass 2016-03-16 07:45:41 -06:00 committed by Tom Rini
parent 21c2975a94
commit 7b0bbd886d
1 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
tools/fit_image.c
View File

@ -329,7 +329,7 @@ static int fit_build(struct image_tool_params *params, const char *fname)
if (ret < 0) { if (ret < 0) {
fprintf(stderr, "%s: Failed to build FIT image\n", fprintf(stderr, "%s: Failed to build FIT image\n",
params->cmdname); params->cmdname);
goto err; goto err_buf;
} }
size = ret; size = ret;
fd = open(fname, O_RDWR | O_CREAT | O_TRUNC | O_BINARY, 0666); fd = open(fname, O_RDWR | O_CREAT | O_TRUNC | O_BINARY, 0666);
@ -346,9 +346,12 @@ static int fit_build(struct image_tool_params *params, const char *fname)
goto err; goto err;
} }
close(fd); close(fd);
free(buf);
return 0; return 0;
err: err:
close(fd);
err_buf:
free(buf); free(buf);
return -1; return -1;
} }