brain-hackers_pepepper-mirror/u-boot-brain
1
0
Fork 0
mirror of https://github.com/brain-hackers/u-boot-brain synced 2024-06-09 23:36:03 +09:00
Code Issues Projects Releases Wiki Activity

tools: dumpimage: Provide more feedback on internal errors

Browse Source 
The dumpimage utility errors out in a number of places without providing
sufficient feedback to allow the user to easily determine what has gone
wrong. Add additional error messages to make the cause of the failure
more obvious.

Signed-off-by: Andrew F. Davis <afd@ti.com>
Reviewed-by: Lokesh Vutla <lokeshvutla@ti.com>
This commit is contained in:
Andrew F. Davis 2019-09-17 17:09:33 -04:00 committed by Tom Rini
parent d8a3f5259a
commit 79e984c470
1 changed files with 13 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
tools/dumpimage.c
View File

@ -35,14 +35,23 @@ static int dumpimage_extract_subimage(struct image_type_params *tparams,
if (tparams->verify_header) {
retval = tparams->verify_header((unsigned char *)ptr,
sbuf->st_size, &params);
if (retval != 0)
if (retval != 0) {
fprintf(stderr, "%s: failed to verify header of %s\n",
params.cmdname, tparams->name);
return -1;
}
/*
* Extract the file from the image
* if verify is successful
*/
if (tparams->extract_subimage) {
retval = tparams->extract_subimage(ptr, &params);
if (retval != 0) {
fprintf(stderr, "%s: extract_subimage failed for %s\n",
params.cmdname, tparams->name);
return -3;
}
} else {
fprintf(stderr,
"%s: extract_subimage undefined for %s\n",
@ -175,6 +184,9 @@ int main(int argc, char **argv)
* image type. Returns the error code if not matched
*/
retval = dumpimage_extract_subimage(tparams, ptr, &sbuf);
if (retval)
fprintf(stderr, "%s: Can't extract subimage from %s\n",
params.cmdname, params.imagefile);
} else {
/*
* Print the image information for matched image type